feat(clickhouse): adding user creation support#2746
Conversation
| mysql_port: 0 | ||
| postgresql_port: 0 |
There was a problem hiding this comment.
i wanted to explicitly disabled it in my case, but looking at deeper into the config (clickhouse docs are sometimes hard to follow), it's not necessary
|
Thanks for your comments, I’ll get back to you with some changes based on your feedback. I also found a few minor issues in the last few days while I was testing my changes. |
sandydoo
left a comment
sandydoo
left a comment
There was a problem hiding this comment.
Looking good! My only request is to rename the options.
For example, instead of keeperEnable, we prefer keeper.enable. Same for the rest.
I'll make sure to document this somewhere for the future.
|
@sandydoo i made the changes |
| keeperPort = lib.mkOption { | ||
| type = types.port; | ||
| description = "Which port to run clickhouse keeper service on."; | ||
| default = 9181; | ||
| }; | ||
|
|
||
| raftPort = lib.mkOption { | ||
| type = types.port; | ||
| description = "Which http port to use clickhouse keeper for raft consensus."; | ||
| default = 9234; | ||
| }; |
There was a problem hiding this comment.
keeperPort -> keeper.port.
raftPort -> keeper.raft.port? Does nesting under keeper make sense? Not familiar with this thing.
2 participants
Current Clickhouse implementation doesn't allow to create a user or modify any behavior.
Additionally I run into issues when try to run migration scripts due to lacking keeper integration and configuration for it.
Also macro support wasn't enabled.