reload: exclude devenv state dir from hot-reload watch set#2806
Open
ndam-hexagon wants to merge 1 commit into
Open
reload: exclude devenv state dir from hot-reload watch set#2806ndam-hexagon wants to merge 1 commit into
ndam-hexagon wants to merge 1 commit into
Conversation
The reload watch set was built from the eval cache's file_input table, which records every path Nix reads during evaluation. Reads under .devenv/ ended up including the eval cache's own SQLite WAL/SHM sidecars; each reload rewrote the WAL, the watcher fired, and shell reload looped forever. Filter watch candidates by self.dotfile in DevenvShellBuilder, and also add the dotfile dir to CachingConfig.excluded_paths so devenv state never enters the eval cache as a tracked input. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
|
Maybe we should skip individual devenv files? I'm worried that someone might store something into DEVENV_STATE and expect the reload to work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reload watch set was built from the eval cache's file_input table, which records every path Nix reads during evaluation. Reads under .devenv/ ended up including the eval cache's own SQLite WAL/SHM sidecars; each reload rewrote the WAL, the watcher fired, and shell reload looped forever.
Filter watch candidates by self.dotfile in DevenvShellBuilder, and also add the dotfile dir to CachingConfig.excluded_paths so devenv state never enters the eval cache as a tracked input.