bug: improve garage service and startup + tests#2846
Open
gabyx wants to merge 8 commits into
Open
Conversation
gabyx
commented
May 19, 2026
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure Garage’s configureScript is executed reliably when using process-compose, addressing issue #2840 where the configuration step was not being run.
Changes:
- Refactors the Garage module header/formatting and introduces a dedicated
processes.garage-configureprocess to run the configuration script after Garage becomes ready. - Adjusts process/task ordering so the Garage process runs after a setup task creates the state directories.
- Renames the module’s option namespace from
services.garagetocustodian.services.garage.
Comments suppressed due to low confidence (2)
src/modules/services/garage.nix:11
- The module option path was changed from
services.garagetocustodian.services.garage, which is a breaking change and will also break existing in-repo usage (e.g.tests/garage/devenv.nixstill configuresservices.garage). Unless there is a broader rename, this should stay underservices.garage; otherwise add a compatibility shim (e.g.mkRenamedOptionModule) and update all internal references accordingly.
types = lib.types;
parsePort = addr: lib.toInt (lib.last (lib.splitString ":" addr));
src/modules/services/garage.nix:71
- Because the option path was renamed here, make sure all user-facing strings and internal references are updated to match (e.g. the assertion messages later in this module still mention
services.garage.*). If the intention is not to rename the public API, please revert back tooptions.services.garage/config.services.garageinstead.
package = lib.mkOption {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@sandydoo: Thanks for merging this. Improves Garage, and adds the missing bucket test. |
Contributor
Author
|
@sandydoo : this needs further improvements. I am working on it. since the whole setup is not good. also |
Contributor
Author
|
Is good to be merged, IMO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2840