hook: clear stale exit-dir state#2855
Open
sweenu wants to merge 1 commit into
Open
Conversation
Bypass shell-level rm overrides when cleaning .devenv/exit-dir. Also drop leftover exit-dir files before launching a new shell so a failed cleanup cannot redirect the next shell exit to an old path. Amp-Thread-ID: https://ampcode.com/threads/T-019e45b1-4096-72dd-8db0-1aafe8bcfa67 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: PR made with Claude and reviewed by me
Problem
Exiting the devenv shell was
cding me into a "random" directory, which was in fact the directory in.devenv/exit-dirthat hadn't gotten cleanup correctly because myrmcommand in fish is an alias toecho "Stop using rm, put in the trash".Summary of changes
rmoverrides when the shell hooks clean up.devenv/exit-dir.devenv/exit-dirbefore launching a new shell, so a failed cleanup cannot redirect a later shell exit to an old pathTest plan
devenv shell -- cargo fmt --checkdevenv shell -- cargo nextest run -p devenv --test hook_outer_shell_survives