Skip to content

RBF nsequence: non-canonical 0x01, only on inputs[0] #3302

Description

@bc1cindy

The RBF sequence is 0x00000001, set only on inputs[0]. On v2 txs 0x01 also adds an unintended 1-block BIP-68 timelock, and the odd value plus the mixed [0x01, MAX, …] pattern fingerprint the wallet on-chain, which is bad for payjoin and other collaborative txs.

Should use the canonical 0xFFFFFFFD on every input. Fix in cake-tech/bitcoin_base#12

ref: payjoin/rust-payjoin#1597

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions