Skip to content

Resolve automatic validation findings #43

Description

@DLondonoD

Problem description
Automatic validation of PRs resulting in some hints.

Expected behavior

We reviewed all validation hints and resolved them as follows:

  • S-211 (line 1126) – AccessTokenCredential: No change. This is a false positive caused by discriminator-based schema resolution.
  • S-313 (line 1133) – accessToken: No change. Tokens are intentionally opaque and implementation-specific.
  • S-313 (line 1455) – AppManifest.version: No change. We prefer to keep application versioning unconstrained for now.
  • S-313 (line 1493) – appRepo.userName: No change. Repository usernames are provider-specific and should remain free-form.
  • S-313 (line 1499) – appRepo.credentials: No change. Credentials must remain opaque and should not be constrained by a generic pattern.
  • S-313 (line 1517) – appRepo.checksum: Change will be applied. We will add a validation pattern because the field already has well-defined checksum semantics.
  • S-313 (line 1546) – componentName: No change. This is a logical component name and should remain flexible.
  • S-313 (line 1625) – ClusterInfo.name: No change. Cluster names are human-readable and provider-defined.
  • S-313 (line 1638) – ClusterInfo.version: Change will be applied. We will add a version pattern because this field represents a Kubernetes version.
  • S-313 (line 1649) – EdgeCloudProvider: No change. This is a human-readable provider name.
  • S-313 (line 1653) – EdgeCloudRegion: No change. This is a provider-defined human-readable region name.
  • S-313 (line 1700) – EdgeCloudZoneName: No change. This is a human-readable zone name.
  • S-313 (line 1736) – Fqdn: Change will be applied. We will add format: hostname.
  • S-313 (line 1787) – K8sNetworking.primaryNetwork.provider: No change. CNI provider names should remain free-form.
  • S-313 (line 1792) – K8sNetworking.primaryNetwork.version: No change. We prefer to keep it free-form because versioning may vary depending on the CNI implementation.
  • S-313 (line 1805) – additionalNetworks[].name: No change. This is a logical network name and does not need a generic pattern.
  • S-313 (line 1839) – AdditionalStorage[].name: No change. This is a free-form storage identifier.
  • S-313 (line 1850) – AdditionalStorage[].mountPoint: No change. We do not want to over-constrain valid path conventions.
  • S-313 (line 1884) – KubernetesNodePool.name: No change. This is a logical node pool name and should remain flexible.
  • S-313 (line 2106) – KubernetesResources.version: Change will be applied. We will add a version pattern because this field represents a minimum Kubernetes version.
  • S-313 (line 2309) – Uri: Change will be applied. We will add format: uri.
  • S-211 (lines 2346, 2348, 2350, 2352, 2354, 2356, 2358, 2360, 2362) – response aliases: Change will be applied. These aliases are unused and duplicate the existing Generic... response definitions, so they will be removed.

Alternative solution

Additional context

A pull request will be generated with these changes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions