For new charms, consider testing that charmcraft pack works (or at least charmcraft.yaml syntax is as expected) before adding the charm to charms.json
This would improve the developer experience for people who are adding charms to charmcraftcache for the first time
Although, to improve the DX, maybe it would be better to improve the documentation so that people are less afraid of breaking the build (since it's fine if the build is broken for a short period of time)
Potential downsides:
- delay for adding new charm (needs to be built twice before cache is available instead of once)—could mitigate this by only checking syntax, or trying first minute of build & seeing if any issues
- new issue would have to be created when the build is fixed (for security reasons, we only parse information from the issue when it's opened [so that it follows the template format]. if an issue is edited, the contents might not match the template & that could create injection issues/parsing issues if contents don't match template)—might be confusing to need to open another issue
For new charms, consider testing that
charmcraft packworks (or at least charmcraft.yaml syntax is as expected) before adding the charm to charms.jsonThis would improve the developer experience for people who are adding charms to charmcraftcache for the first time
Although, to improve the DX, maybe it would be better to improve the documentation so that people are less afraid of breaking the build (since it's fine if the build is broken for a short period of time)
Potential downsides: