Icon names in Icon props are out-of-date

The Icon component's props define a set of expected icon names here:
https://github.com/canonical/react-components/blob/60dd4449c266b6d3d08dbb9ec6d4a164162a3944/src/components/Icon/Icon.tsx#L7

However, this is out-of-date with the current state of Vanilla.

<details>
<summary>
The following icons are missing (click to expand)
</summary>
<ul>
  <li>add-canvas</li>
  <li>add-logical-volume</li>
  <li>add-partition</li>
  <li>applications</li>
  <li>archive</li>
  <li>arrow-bottom-left</li>
  <li>arrow-bottom-right</li>
  <li>arrow-down</li>
  <li>arrow-left</li>
  <li>arrow-right</li>
  <li>arrow-top-left</li>
  <li>arrow-top-right</li>
  <li>arrow-up</li>
  <li>back-to-top</li>
  <li>begin-downloading</li>
  <li>blueprint</li>
  <li>book</li>
  <li>bundle</li>
  <li>canvas</li>
  <li>certificate</li>
  <li>certification</li>
  <li>change-version</li>
  <li>chevron-left</li>
  <li>chevron-right</li>
  <li>cluster-host</li>
  <li>comments</li>
  <li>conflict</li>
  <li>conflict-grey</li>
  <li>conflict-resolution</li>
  <li>conflict-resolution-grey</li>
  <li>connected</li>
  <li>contact</li>
  <li>containers</li>
  <li>contextual-menu</li>
  <li>controllers</li>
  <li>copy-to-clipboard</li>
  <li>credit-card</li>
  <li>cursor</li>
  <li>desktop</li>
  <li>disconnect</li>
  <li>edit</li>
  <li>error-grey</li>
  <li>export</li>
  <li>exposed</li>
  <li>file</li>
  <li>file-blank</li>
  <li>filter</li>
  <li>folder</li>
  <li>fork</li>
  <li>fullscreen</li>
  <li>get-link</li>
  <li>gift</li>
  <li>halfscreen-bar</li>
  <li>heading</li>
  <li>highlight-off</li>
  <li>highlight-on</li>
  <li>home</li>
  <li>image</li>
  <li>import</li>
  <li>in-progress</li>
  <li>inspector-debug</li>
  <li>iso</li>
  <li>loading-steps</li>
  <li>location</li>
  <li>lock-locked</li>
  <li>lock-locked-active</li>
  <li>lock-unlock</li>
  <li>log-out</li>
  <li>machines</li>
  <li>map</li>
  <li>maximise-bar</li>
  <li>minimise-bar</li>
  <li>models</li>
  <li>mount</li>
  <li>mount-2</li>
  <li>notifications</li>
  <li>open-terminal</li>
  <li>pause</li>
  <li>pin</li>
  <li>plans</li>
  <li>play</li>
  <li>pods</li>
  <li>power-error</li>
  <li>power-off</li>
  <li>power-on</li>
  <li>priority-critical</li>
  <li>priority-high</li>
  <li>priority-low</li>
  <li>priority-medium</li>
  <li>priority-negligible</li>
  <li>priority-unknown</li>
  <li>private-key</li>
  <li>profile</li>
  <li>profiles</li>
  <li>question</li>
  <li>quote</li>
  <li>repository</li>
  <li>restart</li>
  <li>revisions</li>
  <li>security</li>
  <li>security-error</li>
  <li>security-tick</li>
  <li>security-warning</li>
  <li>select</li>
  <li>select-add</li>
  <li>select-remove</li>
  <li>settings</li>
  <li>single-host</li>
  <li>snapshot</li>
  <li>snooze</li>
  <li>sort-both</li>
  <li>sort-down</li>
  <li>sort-up</li>
  <li>starred</li>
  <li>statistics</li>
  <li>status</li>
  <li>status-failed-small</li>
  <li>status-in-progress</li>
  <li>status-in-progress-small</li>
  <li>status-queued</li>
  <li>status-queued-small</li>
  <li>status-succeeded-small</li>
  <li>status-waiting</li>
  <li>status-waiting-small</li>
  <li>stop</li>
  <li>submit-bug</li>
  <li>success-grey</li>
  <li>switcher</li>
  <li>switcher-dashboard</li>
  <li>switcher-environments</li>
  <li>tag</li>
  <li>task-outstanding</li>
  <li>thumbs-down</li>
  <li>thumbs-up</li>
  <li>tidy</li>
  <li>timed-out</li>
  <li>timed-out-grey</li>
  <li>toggle-side-nav</li>
  <li>topic</li>
  <li>turn-off-notification</li>
  <li>unit-pending</li>
  <li>unit-running</li>
  <li>units</li>
  <li>unmount</li>
  <li>unstarred</li>
  <li>upload</li>
  <li>usb</li>
  <li>user-group</li>
  <li>video-play</li>
  <li>warning-grey</li>
  <li>website</li>
</ul>
</details>

This is quite a few missing icons, and the type currently allows for other strings to be passed in, so I'm not sure how high-priority it is to add these icons to the props.
https://github.com/canonical/react-components/blob/60dd4449c266b6d3d08dbb9ec6d4a164162a3944/src/components/Icon/Icon.tsx#L54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Icon names in Icon props are out-of-date #1188

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Icon names in Icon props are out-of-date #1188

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions