Skip to content

Attach signedBy to the transaction and lookup during execute #1891

@mjuchli-da

Description

@mjuchli-da

Why is the wallet gateway actually taking the signedBy field from the executeParams and not the transaction itself here:

const { partyId, signature, signedBy } = executeParams
?

  • signedBy should be described better as it represents the field needed in the ledger api:
    The fingerprint/id of the keypair used to create this signature and needed to verify.
  • So this should always be the fingerprint used of the party during the sign step
  • Currently we return the signedBy (and partyId for that matter) from the sign endpoint and use it as params during the execute endpoint.

Instead, we should attach these properties to the transaction and just look up signedBy (and possibly signedByParty)  during execute.

Please question this solution/assumption, it might be wrong

Metadata

Metadata

Type

No fields configured for Task.

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions