From 937082c56d8fb648feeeaa581f8e9078d7df1cff Mon Sep 17 00:00:00 2001 From: Facundo Arancet Iza Date: Wed, 17 Mar 2021 07:44:15 -0300 Subject: [PATCH 1/5] Changed firstName propery to just name --- somedoe.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/somedoe.js b/somedoe.js index a3963d7..2985b52 100644 --- a/somedoe.js +++ b/somedoe.js @@ -1,9 +1,9 @@ var person = { - firstName: "john", - lastName : "doe", + name: "John", + lastName : "Doe", id : 5566, fullName : function() { - return this.firstName + " " + this.lastName; + return this.name + " " + this.lastName; } }; From 0a696d3ac90ca8ddb2f809a8341646540c5c0076 Mon Sep 17 00:00:00 2001 From: Facundo Arancet Iza Date: Wed, 17 Mar 2021 07:47:13 -0300 Subject: [PATCH 2/5] Added string interpolation to fullName method --- somedoe.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/somedoe.js b/somedoe.js index a3963d7..aa89bf2 100644 --- a/somedoe.js +++ b/somedoe.js @@ -3,7 +3,7 @@ var person = { lastName : "doe", id : 5566, fullName : function() { - return this.firstName + " " + this.lastName; + return `${this.firstName} ${this.lastName}`; } }; From dca6e2d502f8e6e4cdda01e40d9d5bfc5a5d7596 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Agust=C3=ADn=20Madrid?= Date: Tue, 5 Mar 2024 08:53:13 -0300 Subject: [PATCH 3/5] fix --- somedoe.js | 1 + 1 file changed, 1 insertion(+) diff --git a/somedoe.js b/somedoe.js index 2985b52..2201e49 100644 --- a/somedoe.js +++ b/somedoe.js @@ -1,4 +1,5 @@ var person = { + firstName: "john", name: "John", lastName : "Doe", id : 5566, From 8e5066470bdba0f681e11c0f101629afcac5fdb6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Agust=C3=ADn=20Madrid?= Date: Tue, 5 Mar 2024 08:54:05 -0300 Subject: [PATCH 4/5] fix 2 --- somedoe.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/somedoe.js b/somedoe.js index 2201e49..abe78f9 100644 --- a/somedoe.js +++ b/somedoe.js @@ -4,7 +4,7 @@ var person = { lastName : "Doe", id : 5566, fullName : function() { - return this.name + " " + this.lastName; + return `${this.firstName} ${this.lastName}`; } }; From 25c11d5f53b37738166c0815c66b0578baeaf28a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Agust=C3=ADn=20Madrid?= Date: Tue, 5 Mar 2024 08:56:51 -0300 Subject: [PATCH 5/5] Last fix --- somedoe.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/somedoe.js b/somedoe.js index abe78f9..69eb9d7 100644 --- a/somedoe.js +++ b/somedoe.js @@ -1,10 +1,9 @@ var person = { - firstName: "john", name: "John", lastName : "Doe", id : 5566, fullName : function() { - return `${this.firstName} ${this.lastName}`; + return `${this.name} ${this.lastName}`; } };