Support a regular ping

[joelittlejohn]

The Slack RTM docs state the following:

Clients should try to quickly detect disconnections, even in idle periods, so that users can easily tell the difference between being disconnected and everyone being quiet. Not all web browsers support the WebSocket ping spec, so the RTM protocol also supports ping/pong messages. When there is no other activity clients should send a ping every few seconds.

It would be great if I could simply supply an argument to connect to turn on these ping messages, e.g.

(connect :ping-interval-seconds 10)

What do you think?

[casidiablo]

I think it makes sense... do you want to do it or should I add it to my TODO list?

[joelittlejohn]

I might attempt to tackle this once I'm more familiar with the Slack API and your library.

Feel free to add this to your TODO list though, I feel like there's a wide variety of ways to achieve this (a periodic send) and it might be best if you choose the one that fits your sensibilities best 😄

I've added something to my own code for now but I think it would be a useful addition to the core. Here's my code btw:

 (go-loop []
    (<! (timeout wait-ms))
    (when (>! dispatcher {:id (rand-int) :type :ping})
      (recur)))

☝️ just threw this together so I have no idea if it's the best approach.