Python Packaging

[mheap]

Good morning!

I'd like to submit some PRs to ssh-ident to allow the installation of the project via pip. The initial work can be seen here.

I have a plan to add tests and perform some refactorings in the future, but wanted to see if you were open to receiving the changes before I continued any further.

If I do the work, would you merge it?

Thanks, Michael

[ccontavalli]

Hello,

sorry for delay! So...

1. PIP support sounds great. I'll try to look at your code asap, but may take me another week or two. My only concern is that so far ssh-ident has been a self contained script, there's a few people that just wget the file, and run it.

I think it'd be good to maintain this property? Not sure how to reconcile it with splitting it into two files.

2. Adding tests would be great!

3. I'm certainly open to receiving refactoring changes, and new features, would be great :) But at the same time, if you can, I recommend sending small incremental changes, or a preview diff so iff there is any issue, we can try to iron it out before you invest too much time on it?

[mheap]

We would lose the "wget and run" capability, which is my only concern too. The ability to install via pip should mitigate that somewhat though.

The refactoring changes would be small. They would primarily be changes to make testing easier. Very few functionality changes. I can of course start with a PR so that you can see the changes as they are developed.

If you're ok with losing the capability to download via wget in exchange for test coverage, I'll start on the work soon

[go2null]

It would be great to be able to run standalone.
Currently, I just git clone and then ln -s to ~/bin.
Updates are a simple git pull.

[mheap]

That use case would still work. There's still a single entry point that you can symlink to ~/bin.

It's only the wget https://raw.githubusercontent.com/ccontavalli/ssh-ident/master/ssh-ident -O ~/bin/ssh method that would no longer work

[go2null]

Great! Thanks for the clarification.

[bendikro]

I've actually implemented this in #37. Downloading only the main ssh-ident script should still work as before.