diff --git a/Code_Review.txt b/Code_Review.txt new file mode 100644 index 0000000..c7327d4 --- /dev/null +++ b/Code_Review.txt @@ -0,0 +1,27 @@ +1) Naming +- variable names are clear + +2) Code structure +- entire coding inside main - split up into separate methods + +3) Error handling +- program checks to see if files exist + +- Doesnt't handle file is empty + +4) File assumptions +- program assumes the file is small and plain text - add validate file content + +5) OOP Principles +- procedural +- all within main +- introducee clases + +6) Output +- Output is clear and simple +- make output more user friendly + +7) Program logic +- Works +- doesn't handle contraction words +- use smarter regex