From 573fdab532daaccc726217d2329267f576f2997c Mon Sep 17 00:00:00 2001 From: snowy988 Date: Wed, 30 Jul 2025 06:21:17 +0100 Subject: [PATCH 1/2] Create Code_Review.txt --- Code_Review.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 Code_Review.txt diff --git a/Code_Review.txt b/Code_Review.txt new file mode 100644 index 0000000..8b13789 --- /dev/null +++ b/Code_Review.txt @@ -0,0 +1 @@ + From ef10d2682a2cd00561a2fb45e9cfc04303d58283 Mon Sep 17 00:00:00 2001 From: snowy988 Date: Wed, 30 Jul 2025 07:17:28 +0100 Subject: [PATCH 2/2] Update Code_Review.txt --- Code_Review.txt | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/Code_Review.txt b/Code_Review.txt index 8b13789..c7327d4 100644 --- a/Code_Review.txt +++ b/Code_Review.txt @@ -1 +1,27 @@ +1) Naming +- variable names are clear +2) Code structure +- entire coding inside main - split up into separate methods + +3) Error handling +- program checks to see if files exist + +- Doesnt't handle file is empty + +4) File assumptions +- program assumes the file is small and plain text - add validate file content + +5) OOP Principles +- procedural +- all within main +- introducee clases + +6) Output +- Output is clear and simple +- make output more user friendly + +7) Program logic +- Works +- doesn't handle contraction words +- use smarter regex