scheme.h uses `Spopcount` but does not define it

[ThePuzzlemaker]

In release 10.3.0, as well as on master as of 7842937, the generated scheme.h as configured by ./configure --threads --installprefix=/usr --libkernel uses Spopcount for Sstencil_vector_length, but it is not defined in scheme.h.

[burgerrg]

Thank you for finding this! It looks like Spopcount is not exported from Chez Scheme, and there's no definition for it in scheme.h.

popcount.h is included in a few places. We would need to export a definition of Spopcount from one of the C files.

ChezScheme/c/popcount.h

Lines 24 to 34 in 7842937

	#if ptr_bits == 32
	static int Spopcount(uptr x)
	{
	return Spopcount_32((U32)x);
	}
	#elif ptr_bits == 64
	static int Spopcount(uptr x)
	{
	return Spopcount_32((U32)(x & 0xFFFFFFFF)) + Spopcount_32((U32)(x >> 32));
	}
	#endif

We would need to add (export "int" "Spopcount" "(uptr)") before:

ChezScheme/s/mkheader.ss

Lines 343 to 346 in 7842937

	(def "Sstencil_vector_length(x)"
	(format "Spopcount(((uptr)~a)>>~d)"
	(access "x" stencil-vector type)
	($ stencil-vector-mask-offset)))