Skip to content

SRTCP handling for maximum_lifetime is missing in srtp.c file #761

@poojas123218

Description

@poojas123218

File - https://github.com/cisco/libsrtp/tree/main/srtp/srtp.c

Function - srtp_unprotect_rtcp_mki()

When SRTCP packets count reaches hard limit i.e 2^31 is reached and handling of this event is done. But this handling where SRTCP packets are checked and based on hard/soft limit event is raised is missing for SRTCP.
Handling for SRTP is present in function srtp_unprotect_mki().

Can you please confirm why this handling is missed for SRTCP.

Missed handling:

switch (srtp_key_limit_update(session_keys->limit)) {
case srtp_key_event_normal:
break;
case srtp_key_event_soft_limit:
srtp_handle_event(ctx, stream, EVENT_KEY_SOFT_LIMIT);
break;
case srtp_key_event_hard_limit:
srtp_handle_event(ctx, stream, EVENT_KEY_HARD_LIMIT);
return srtp_err_status_key_expired;
default:
break;

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions