Primer, sec. "cs:info Element" and sec. "cs:bibliography Element" are not valid CSL

[lucabalsanelli]

Primer, sec. "cs:info Element" and sec. "cs:bibliography Element" are not valid CSL according to https://validator.citationstyles.org/, for 2 errors.

1. This

<info>
  <--! omissis -->
  <category citation-format="author-date"/>
  <category field="science">
  <--! omissis -->
</info>

should be (issue: end tag)

<info>
  <--! omissis -->
  <category citation-format="author-date"/>
  <category field="science"/>
  <--! omissis -->
</info>

2. and this

<bibliography>
  <!-- omissis -->
  <layout suffix="." delimiter=", ">
    <group delimiter=". ">
      <!-- omissis -->
    </group>
    <group>
      <!-- omissis -->
    </group>
    <text variable="page"/>
  </layout>
</bibliography>

should be (issue delimiter attribute in cs:layout element)

<bibliography>
  <!-- omissis -->
  <layout suffix=".">
    <group delimiter=", ">
      <group delimiter=". ">
        <!-- omissis -->
      </group>
      <group>
        <!-- omissis -->
      </group>
      <text variable="page"/>
    </group>
  </layout>
</bibliography>

I wanted to edit in place but I didn't know which branch since it's not possible on master.

[bwiernik]

Thanks! Can you open a pull request against master? I can take care of any other branches

[lucabalsanelli]

Did it. I don't understand if it's me that can/should merge this pull request. I never exactly got the handle of pull requests on GitHub.

[bwiernik]

I don't see any pull request in the CSL repo. Maybe you accidentally opened it on your fork? Can you give me a link to what you are seeing?

[denismaier]

The pull request was against @lucabalsanelli's fork, see here.

@lucabalsanelli You need to open the pull request against the master branch in this repo. Here's how: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

[lucabalsanelli]

Thanks for the "accidentally", but I in fact never grabbed the social features of github... I'm going to read the documentation, so hopefully I'm going to switch from being a git user to a git+hub user.

[lucabalsanelli]

did my best to read the github manual