Improve memory efficiency in file reading and add tests#14
Merged
Conversation
- Replaced the previous file reading implementation which loaded the entire file into memory (causing potential OOM errors on large files) with a line-by-line buffered approach. - The new implementation uses `tokio::fs::File`, `tokio::io::BufReader`, and `reader.lines()` to read the file incrementally. This drastically reduces peak memory usage, especially for large input files, making the function more robust.
Member
|
It looks good! Thank you for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the file reading implementation to use a line-by-line buffered approach, enhancing memory efficiency for large files. Add comprehensive tests for the file read and hash functions to ensure robustness.