Skip to content

Commit 2013518

Browse files
committed
fix(tests): update GiveBillTransactorTest and SwapViewModelErrorTest
- Add missing verifiedFiatCalculator parameter to GiveBillTransactor constructor calls - Stub tokenCoordinator.balanceForToken and set token address to Mint.usdf in sell test so balance check passes and sell error path is exercised Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
1 parent 7d9e37b commit 2013518

2 files changed

Lines changed: 14 additions & 1 deletion

File tree

apps/flipcash/shared/tokens/src/test/kotlin/com/flipcash/app/tokens/ui/SwapViewModelErrorTest.kt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@ import com.getcode.opencode.exchange.Exchange
1212
import com.getcode.opencode.exchange.VerifiedFiat
1313
import com.getcode.opencode.exchange.VerifiedFiatCalculator
1414
import com.getcode.opencode.model.accounts.AccountCluster
15+
import com.getcode.opencode.model.financial.Fiat
1516
import com.getcode.opencode.model.financial.LocalFiat
17+
import com.getcode.solana.keys.Mint
1618
import com.getcode.opencode.model.financial.Token
1719
import com.getcode.opencode.model.financial.TokenWithBalance
1820
import com.getcode.opencode.utils.generate
@@ -124,10 +126,14 @@ class SwapViewModelErrorTest {
124126
@Test
125127
fun `sell failure shows buySellFailed error`() = runTest(mainCoroutineRule.dispatcher) {
126128
dispatchers = TestDispatchers(testScheduler)
129+
// Ensure balance check passes so the sell call is reached
130+
every { tokenCoordinator.balanceForToken(any<Token>()) } returns Fiat(999_999.0)
127131
whenever(transactionController.sell(any(), any(), any()))
128132
.thenReturn(Result.failure(RuntimeException("sell failed")))
129133

130-
val token = mockk<Token>(relaxed = true)
134+
val token = mockk<Token>(relaxed = true) {
135+
every { address } returns Mint.usdf
136+
}
131137
val tokenWithBalance = mockk<TokenWithBalance>(relaxed = true) {
132138
every { this@mockk.token } returns token
133139
}

services/opencode/src/test/kotlin/com/getcode/opencode/internal/transactors/GiveBillTransactorTest.kt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package com.getcode.opencode.internal.transactors
22

33
import com.getcode.opencode.controllers.MessagingController
44
import com.getcode.opencode.controllers.TransactionController
5+
import com.getcode.opencode.exchange.VerifiedFiatCalculator
56
import com.getcode.opencode.internal.extensions.exchangeDataFor
67
import com.getcode.opencode.internal.manager.VerifiedState
78
import com.getcode.opencode.model.accounts.AccountCluster
@@ -34,6 +35,7 @@ class GiveBillTransactorTest {
3435

3536
private val messagingController = mockk<MessagingController>(relaxed = true)
3637
private val transactionController = mockk<TransactionController>(relaxed = true)
38+
private val verifiedFiatCalculator = mockk<VerifiedFiatCalculator>(relaxed = true)
3739

3840
private val payloadFactory = PayloadFactory { _, _, _ ->
3941
PayloadResult(rendezvous = mockk(relaxed = true), codeData = emptyList())
@@ -45,6 +47,7 @@ class GiveBillTransactorTest {
4547
transactionController = transactionController,
4648
scope = scope,
4749
payloadFactory = payloadFactory,
50+
verifiedFiatCalculator = verifiedFiatCalculator,
4851
)
4952
}
5053

@@ -142,6 +145,7 @@ class GiveBillTransactorTest {
142145
transactionController = transactionController,
143146
scope = this,
144147
payloadFactory = factory,
148+
verifiedFiatCalculator = verifiedFiatCalculator,
145149
)
146150

147151
val providedNonce = listOf<Byte>(10, 20, 30, 40)
@@ -172,6 +176,7 @@ class GiveBillTransactorTest {
172176
transactionController = transactionController,
173177
scope = this,
174178
payloadFactory = factory,
179+
verifiedFiatCalculator = verifiedFiatCalculator,
175180
)
176181

177182
val nonce = listOf<Byte>(10, 20, 30, 40)
@@ -195,12 +200,14 @@ class GiveBillTransactorTest {
195200
transactionController = transactionController,
196201
scope = this,
197202
payloadFactory = factory,
203+
verifiedFiatCalculator = verifiedFiatCalculator,
198204
)
199205
val transactor2 = GiveBillTransactor(
200206
messagingController = messagingController,
201207
transactionController = transactionController,
202208
scope = this,
203209
payloadFactory = factory,
210+
verifiedFiatCalculator = verifiedFiatCalculator,
204211
)
205212

206213
setupWith(transactor1)

0 commit comments

Comments
 (0)