Skip to content

Commit 2275434

Browse files
committed
fix(ci): scope manifest commit to avoid committing CI artifacts
Replace actions-js/push (which does git add .) with explicit git commands that only stage manifest files. Add .gitignore entries for vendor/bundle, .bundle, signing keys, and service account files. Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
1 parent 6bc6976 commit 2275434

2 files changed

Lines changed: 20 additions & 5 deletions

File tree

.github/workflows/build-fcash2-upload-android.yml

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -119,11 +119,15 @@ jobs:
119119
run: bash scripts/update-release-manifest.sh
120120

121121
- name: Commit & push manifest
122-
uses: actions-js/push@master
123-
with:
124-
message: "build: update release manifest"
125-
branch: "code/cash"
126-
github_token: ${{ secrets.BOT_GITHUB_TOKEN }}
122+
env:
123+
GITHUB_TOKEN: ${{ secrets.BOT_GITHUB_TOKEN }}
124+
run: |
125+
git config user.name "github-actions[bot]"
126+
git config user.email "github-actions[bot]@users.noreply.github.com"
127+
git add .well-known/release-manifest.json buildSrc/src/main/java/Packaging.kt
128+
git diff --cached --quiet && echo "No changes to commit" && exit 0
129+
git commit -m "build: update release manifest"
130+
git push https://x-access-token:${GITHUB_TOKEN}@github.com/${{ github.repository }}.git HEAD:code/cash
127131
128132
- name: Upload build artifacts
129133
uses: actions/upload-artifact@v4

.gitignore

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,17 @@ fastlane/report.xml
2121
*.env.*
2222
.claude/
2323

24+
# Bundler (Ruby gems installed during CI)
25+
.bundle/
26+
vendor/bundle/
27+
28+
# Signing keys decoded during CI
29+
key/
30+
apps/flipcash/app/key/
31+
32+
# Service account keys
33+
serviceAccount.json
34+
2435
# Maestro screenshot test artifacts
2536
maestro/screenshots/results/
2637
maestro/screenshots/diffs/

0 commit comments

Comments
 (0)