Skip to content

Commit 6777980

Browse files
committed
build: split build and deploy for flipcash to optimize CI
Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
1 parent 7ddfdcd commit 6777980

2 files changed

Lines changed: 85 additions & 54 deletions

File tree

.github/workflows/build-fcash-upload-android.yml

Lines changed: 76 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@ env:
44
main_project_module: apps:flipcash:app
55
playstore_name: Flipcash
66

7+
# Cancel in-progress workflow runs if a job fails
8+
concurrency:
9+
group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.event.inputs.track }}-${{ github.event.inputs.release_status }}
10+
cancel-in-progress: true
11+
712
on:
813
workflow_dispatch:
914
inputs:
@@ -99,6 +104,18 @@ jobs:
99104
key: gradle-${{ hashFiles('**/*.gradle*', '**/gradle.properties') }}
100105
restore-keys: gradle-
101106

107+
- name: Upload Setup Artifacts
108+
uses: actions/upload-artifact@v4
109+
with:
110+
name: setup-files
111+
path: |
112+
${{ steps.google_services_json_file.outputs.filePath }}
113+
${{ steps.service_account_json_file.outputs.filePath }}
114+
${{ steps.signing_key.outputs.filePath }}
115+
./apps/flipcash/app/key/key
116+
./local.properties
117+
if-no-files-found: error
118+
102119
tests:
103120
needs: setup
104121
runs-on: ubuntu-latest
@@ -107,74 +124,96 @@ jobs:
107124
with:
108125
fetch-depth: 0
109126

127+
- name: Setup Ruby env
128+
uses: ruby/setup-ruby@v1
129+
with:
130+
ruby-version: 2.7.2
131+
bundler-cache: true
132+
110133
- name: Restore Gradle Cache
111134
uses: actions/cache/restore@v3
112135
with:
113136
path: ~/.gradle/caches
114137
key: gradle-${{ hashFiles('**/*.gradle*', '**/gradle.properties') }}
115138
restore-keys: gradle-
116139

117-
- name: Copy Setup Files
118-
run: |
119-
mkdir -p ./apps/flipcash/app/src
120-
mkdir -p ./key
121-
mkdir -p ./apps/flipcash/app/key
122-
cp ${{ needs.setup.outputs.google_services_json }} ./apps/flipcash/app/src/google-services.json
123-
cp ${{ needs.setup.outputs.service_account_json }} ./serviceAccount.json
124-
cp ${{ needs.setup.outputs.signing_key }} ./key/key
125-
cp ${{ needs.setup.outputs.signing_key }} ./apps/flipcash/app/key/key
126-
echo BUGSNAG_API_KEY=\"${{ secrets.FLIPCASH_BUGSNAG_API_KEY }}\" > ./local.properties
127-
echo GOOGLE_CLOUD_PROJECT_NUMBER=${{ secrets.GOOGLE_CLOUD_PROJECT_NUMBER }} >> ./local.properties
128-
echo MIXPANEL_API_KEY=\"${{ secrets.FLIPCASH_MIXPANEL_API_KEY }}\" >> ./local.properties
140+
- name: Download Setup Artifacts
141+
uses: actions/download-artifact@v4
142+
with:
143+
name: setup-files
144+
path: .
129145

130146
- name: Run tests
131147
run: bundle exec fastlane android flipcash_tests
132148

133-
deploy:
149+
build:
134150
needs: setup
135151
runs-on: ubuntu-latest
136152
steps:
137153
- uses: actions/checkout@v4
138154
with:
139155
fetch-depth: 0
140156

157+
- name: Setup Ruby env
158+
uses: ruby/setup-ruby@v1
159+
with:
160+
ruby-version: 2.7.2
161+
bundler-cache: true
162+
141163
- name: Restore Gradle Cache
142164
uses: actions/cache/restore@v3
143165
with:
144166
path: ~/.gradle/caches
145167
key: gradle-${{ hashFiles('**/*.gradle*', '**/gradle.properties') }}
146168
restore-keys: gradle-
147169

148-
- name: Copy Setup Files
149-
run: |
150-
mkdir -p ./apps/flipcash/app/src
151-
mkdir -p ./key
152-
mkdir -p ./apps/flipcash/app/key
153-
cp ${{ needs.setup.outputs.google_services_json }} ./apps/flipcash/app/src/google-services.json
154-
cp ${{ needs.setup.outputs.service_account_json }} ./serviceAccount.json
155-
cp ${{ needs.setup.outputs.signing_key }} ./key/key
156-
cp ${{ needs.setup.outputs.signing_key }} ./apps/flipcash/app/key/key
157-
echo BUGSNAG_API_KEY=\"${{ secrets.FLIPCASH_BUGSNAG_API_KEY }}\" > ./local.properties
158-
echo GOOGLE_CLOUD_PROJECT_NUMBER=${{ secrets.GOOGLE_CLOUD_PROJECT_NUMBER }} >> ./local.properties
159-
echo MIXPANEL_API_KEY=\"${{ secrets.FLIPCASH_MIXPANEL_API_KEY }}\" >> ./local.properties
160-
161-
- name: Build & deploy Android release
162-
run: bundle exec fastlane android deploy_flipcash
170+
- name: Download Setup Artifacts
171+
uses: actions/download-artifact@v4
172+
with:
173+
name: setup-files
174+
path: .
175+
176+
- name: Build Android release
177+
run: bundle exec fastlane android build_flipcash
163178
env:
164179
STORE_FILE: ${{ needs.setup.outputs.signing_key }}
165180
STORE_PASSWORD: ${{ secrets.KEYSTORE_PASSWORD }}
166181
KEY_ALIAS: ${{ secrets.KEY_ALIAS }}
167182
KEY_PASSWORD: ${{ secrets.KEYSTORE_PASSWORD }}
168-
SERVICE_ACCOUNT_KEY_JSON: ${{ needs.setup.outputs.service_account_json }}
169-
PACKAGE_NAME: com.flipcash.android.app
170-
PLAYSTORE_TRACK: ${{ github.event.inputs.track }}
171-
RELEASE_STATUS: ${{ github.event.inputs.release_status }}
172183

173-
- name: Upload build artifacts
184+
- name: Upload Build Artifacts
174185
uses: actions/upload-artifact@v4
175-
if: always()
176186
with:
177-
name: assets
187+
name: build-assets
178188
path: |
179-
${{ github.workspace }}/apps/flipcash/app/build/outputs/bundle/release
180-
${{ github.workspace }}/apps/flipcash/app/build/outputs/apk/release
189+
${{ github.workspace }}/artifacts/*.aab
190+
${{ github.workspace }}/artifacts/*.txt
191+
if-no-files-found: error
192+
193+
deploy:
194+
needs: [tests, build]
195+
runs-on: ubuntu-latest
196+
steps:
197+
- uses: actions/checkout@v4
198+
with:
199+
fetch-depth: 0
200+
201+
- name: Setup Ruby env
202+
uses: ruby/setup-ruby@v1
203+
with:
204+
ruby-version: 2.7.2
205+
bundler-cache: true
206+
207+
- name: Download Build Artifacts
208+
uses: actions/download-artifact@v4
209+
with:
210+
name: build-assets
211+
path: artifacts/
212+
213+
- name: Deploy to Play Store
214+
run: bundle exec fastlane android deploy_to_play_store
215+
env:
216+
SERVICE_ACCOUNT_KEY_JSON: ${{ needs.setup.outputs.service_account_json }}
217+
PACKAGE_NAME: com.flipcash.android.app
218+
PLAYSTORE_TRACK: ${{ github.event.inputs.track }}
219+
RELEASE_STATUS: ${{ github.event.inputs.release_status }}

fastlane/Fastfile

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -114,45 +114,37 @@ platform :android do
114114
)
115115
end
116116

117-
desc "Build and Deploy a new version of Flipcash to the Google Play Store"
117+
desc "Build and Deploy a new version of Flipcash to the Google Play Store"
118118
lane :deploy_flipcash do
119119
gradle(
120-
task: "clean apps:flipcash:app:bundle", #"clean app:bundleRelease",
120+
task: "clean apps:flipcash:app:bundle",
121121
build_type: "release",
122122
properties: {
123-
#"versionPatch" => ENV["BUILD_NUMBER"],
124123
"android.injected.signing.store.file" => ENV["STORE_FILE"],
125124
"android.injected.signing.store.password" => ENV["STORE_PASSWORD"],
126125
"android.injected.signing.key.alias" => ENV["KEY_ALIAS"],
127126
"android.injected.signing.key.password" => ENV["KEY_PASSWORD"]
128127
}
129128
)
130129

131-
bundletool(
132-
ks_path: ENV["STORE_FILE"],
133-
ks_password: ENV["STORE_PASSWORD"],
134-
ks_key_alias: ENV["KEY_ALIAS"],
135-
ks_key_alias_password: ENV["KEY_PASSWORD"],
136-
bundletool_version: '1.10.0',
137-
aab_path: Actions.lane_context[SharedValues::GRADLE_AAB_OUTPUT_PATH],
138-
apk_output_path: "apps/flipcash/app/build/outputs/apk/release",
139-
verbose: true,
140-
)
130+
sh("mkdir -p ../artifacts && cp #{Actions.lane_context[SharedValues::GRADLE_AAB_OUTPUT_PATH]} ../artifacts/")
131+
sh("cp #{Actions.lane_context[SharedValues::GRADLE_MAPPING_TXT_OUTPUT_PATH]} ../artifacts/") if File.exist?(Actions.lane_context[SharedValues::GRADLE_MAPPING_TXT_OUTPUT_PATH])
132+
end
141133

134+
desc "Deploy a new version of Flipcash to the Google Play Store"
135+
lane :deploy_to_play_store do
142136
validate_play_store_json_key(
143137
json_key: ENV["SERVICE_ACCOUNT_KEY_JSON"]
144138
)
145-
146139
upload_to_play_store(
147140
track: ENV["PLAYSTORE_TRACK"],
148141
release_status: ENV["RELEASE_STATUS"],
149-
aab: Actions.lane_context[SharedValues::GRADLE_AAB_OUTPUT_PATH],
142+
aab: "../artifacts/#{File.basename(Actions.lane_context[SharedValues::GRADLE_AAB_OUTPUT_PATH])}",
150143
skip_upload_apk: true,
151144
skip_upload_changelogs: true,
152145
skip_upload_images: true,
153146
package_name: ENV["PACKAGE_NAME"],
154-
mapping: Actions.lane_context[SharedValues::GRADLE_MAPPING_TXT_OUTPUT_PATH]
155-
# mapping: mapping_file_exists() ? Actions.lane_context[SharedValues::GRADLE_MAPPING_TXT_OUTPUT_PATH] : nil
147+
mapping: File.exist?("../artifacts/#{File.basename(Actions.lane_context[SharedValues::GRADLE_MAPPING_TXT_OUTPUT_PATH])}") ? "../artifacts/#{File.basename(Actions.lane_context[SharedValues::GRADLE_MAPPING_TXT_OUTPUT_PATH])}" : nil
156148
)
157149
end
158150
end

0 commit comments

Comments
 (0)