Skip to content

Commit 13af30a

Browse files
committed
fix(configurator): keep always-open generator from overlapping; update shell title
The redesigned ScaleGenerator is always-open (tall) instead of collapsed, so as a flex child of the panel's scroll container it was compressed below its content — the grid overflowed and overlapped the Apply button and the next card, making the button unclickable in chromium (generator + undo-redo e2e timeouts). Pin the section with flex-shrink: 0 and raise the inputs column above the ramp so the controls are always hit-testable. Also update shell.spec.js to assert the renamed "Core brand colors" card (was "Brand & status colors" before the Colors accordion split). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fg7U9rTiqBgbsPuz9kdWea
1 parent 7836b86 commit 13af30a

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

configurator/src/components/ScaleGenerator.svelte

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -299,6 +299,10 @@
299299
border: 1px solid var(--cfg-border);
300300
border-radius: var(--cfg-radius);
301301
overflow: hidden;
302+
/* In the panel's flex-column scroll container, don't let the section be
303+
compressed below its content — a shrunk grid would overflow and overlap
304+
the Apply button and the next card (chromium hit-testing). */
305+
flex-shrink: 0;
302306
}
303307
304308
.gen__head {
@@ -332,6 +336,10 @@
332336
display: flex;
333337
flex-direction: column;
334338
gap: 12px;
339+
/* Keep the interactive column (Apply/Reset) above the ramp, which is
340+
painted later in DOM order. */
341+
position: relative;
342+
z-index: 1;
335343
}
336344
337345
.ctl-grid {

configurator/tests-e2e/shell.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ test('every destination renders console-clean at 3 widths', async ({ page }) =>
3939
test('every category panel leads with Settings, with All variables collapsed below', async ({ page }) => {
4040
await gotoClean(page);
4141
await sideItem(page, 'Colors').click();
42-
// Inputs-first: the brand-colors card is visible before any raw catalogue.
43-
await expect(page.locator('.panel__card', { hasText: 'Brand & status colors' })).toBeVisible();
42+
// Inputs-first: the core brand-colors card is visible before any raw catalogue.
43+
await expect(page.locator('.panel__card', { hasText: 'Core brand colors' })).toBeVisible();
4444
// The full catalogue lives in a collapsed disclosure.
4545
const allvars = page.locator('details.allvars');
4646
await expect(allvars).toHaveCount(1);

0 commit comments

Comments
 (0)