refactor: Clean up unused code and improve error handling in various components

Author: codevoid048

client-test/src/components/ErrorRoutes.tsx

@@ -59,17 +59,6 @@ export const NetworkErrorRoute: React.FC = () => {
 
 // Unauthorized Page with context
 export const UnauthorizedRoute: React.FC = () => {
-  const [setErrorContext] = useState<any>(null);
-
-  useEffect(() => {
-    const stored = sessionStorage.getItem('authError');
-    if (stored) {
-      setErrorContext(JSON.parse(stored));
-      // Clear the stored error after reading
-      sessionStorage.removeItem('authError');
-    }
-  }, []);
-
   return (
     <UnauthorizedPage />
   );

client-test/src/lib/axios.ts

@@ -48,11 +48,6 @@ axiosInstance.interceptors.request.use(
 // Response interceptor for handling global errors
 axiosInstance.interceptors.response.use(
   (response) => {
-    // Log response time
-    if (response.config?.metadata?.startTime) {
-      const duration = Date.now() - response.config.metadata.startTime;
-      console.log(`Request to ${response.config.url} took ${duration}ms`);
-    }
     return response;
   },
   (error: AxiosError<ApiErrorResponse>) => {

server/app.js

@@ -48,9 +48,9 @@ app.use(helmet({
   referrerPolicy: { policy: "strict-origin-when-cross-origin" }
 }));
 
-app.use(express.json({ limit: '2mb' }));
+app.use(express.json({ limit: '5mb' }));
 
-app.use(express.urlencoded({ limit: '2mb', extended: false }));
+app.use(express.urlencoded({ limit: '5mb', extended: false }));
 
 app.use(cookieParser());
 app.use(passport.initialize());

server/controllers/leaderboardController.js

@@ -66,7 +66,6 @@ export const getLeaderboardData = async (req, res) => {
 
     // Ensure leaderboard is an array
     if (!Array.isArray(leaderboard)) {
-      console.error("Leaderboard is not an array:", typeof leaderboard, leaderboard);
       leaderboard = [];
     }
 

server/lib/db.js

@@ -1,4 +1,6 @@
 import mongoose from "mongoose"
+const { default: cacheService } = await import("../services/cacheService.js");
+const { warmupLeaderboardCache } = await import("../utils/leaderBoardCache.js");
 
 const connectDB = async () => {
     try {
@@ -16,16 +18,25 @@ const connectDB = async () => {
         mongoose.connection.on('error', (error) => {
             console.error('Database connection error:', error.message);
         });
-        
-        // Warmup leaderboard cache after DB is ready (with delay for Redis connection)
-        setTimeout(async () => {
-            try {
-                const { warmupLeaderboardCache } = await import("../utils/leaderBoardCache.js");
-                warmupLeaderboardCache();
-            } catch (error) {
-                console.error('Failed to warmup leaderboard cache:', error.message);
+                
+        async function waitForRedisAndWarmup(attempt = 1) {
+            const maxAttempts = 5;
+            const delay = Math.min(1000 * Math.pow(2, attempt - 1), 10000); // exponential backoff, max 10s
+            
+            if (cacheService.isRedisConnected()) {
+                try {
+                    await warmupLeaderboardCache();
+                } catch (error) {
+                    console.error('Failed to warmup leaderboard cache:', error.message);
+                }
+            } else if (attempt < maxAttempts) {
+                setTimeout(() => waitForRedisAndWarmup(attempt + 1), delay);
+            } else {
+                console.error('Redis was not ready after maximum attempts. Skipping leaderboard cache warmup.');
             }
-        }, 2000); // 2 second delay
+        }
+        
+        waitForRedisAndWarmup();
 
     } catch (error) {
         console.error('Database connection failed:', error.message);

server/middleware/rateLimiter.js

@@ -126,4 +126,4 @@ export const rateLimitMiddleware = (maxRequests = MAX_REQUESTS_PER_WINDOW, windo
 // Specific rate limiters for different operations
 export const challengeUpdateRateLimit = rateLimitMiddleware(5, 60000); // 5 requests per minute for challenge updates
 export const platformUpdateRateLimit = rateLimitMiddleware(3, 120000); // 3 requests per 2 minutes for platform updates
-export const registrationRateLimit = rateLimitMiddleware(5, 60000); // 5 registrations per minute (per IP/user) - prevents spam but allows legitimate usage
+export const registrationRateLimit = rateLimitMiddleware(3, 60000); // 5 registrations per minute (per IP/user) - prevents spam but allows legitimate usage

server/services/cacheService.js

@@ -76,7 +76,7 @@ class CacheService {
                 // Reset metrics
                 this.metrics = { hits: 0, misses: 0, errors: 0, operations: 0 };
             }
-        }, 5 * 60000); // Every 5 minute
+        }, 5 * 60000); // Every 5 minutes
     }
 
     // Generate cache key with namespace
@@ -268,6 +268,11 @@ class CacheService {
             metrics: { ...this.metrics }
         };
     }
+
+    // Check if Redis is connected (regardless of read-only status)
+    isRedisConnected() {
+        return this.redis !== null;
+    }
 }
 
 // Export singleton instance

server/utils/leaderBoardCache.js

@@ -220,7 +220,7 @@ export const warmupLeaderboardCache = async (maxRetries = 3) => {
         updateQueue.forEach(({ reject }) => reject(error));
         updateQueue = [];
 
-        audit.error(error);
+        auditService.error(error);
         throw error;
     } finally {
         isUpdatingLeaderboard = false;