From 49e993b2496a1998f5947f67f40fc4a4e7f71f80 Mon Sep 17 00:00:00 2001 From: Tekbreak Date: Mon, 11 Dec 2023 12:06:32 +0100 Subject: [PATCH 1/2] remove empty object in GB-wls regions --- data/countries/GB.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/countries/GB.yaml b/data/countries/GB.yaml index 1e028738e..26113f595 100644 --- a/data/countries/GB.yaml +++ b/data/countries/GB.yaml @@ -548,7 +548,7 @@ holidays: 1st monday before 09-01: name: en: Summer bank holiday - regions: {} + # regions: # AGY: # name: Anglesey # BGE: From 427fbefcac665a8b671e154e51699958ad5948c0 Mon Sep 17 00:00:00 2001 From: Tekbreak Date: Mon, 11 Dec 2023 12:14:36 +0100 Subject: [PATCH 2/2] fix: build fails without the Json file --- CONTRIBUTING.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index bdb258680..30c614f3f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -10,12 +10,12 @@ If you like to add or change data please take a look at [holidays.yaml specifica 1. Fork the project 2. Create a branch for your changes -3. Build the project: +3. Create Json file and build the project: ``` - npm run build + npm run yaml && npm run build ``` 4. Modify the yaml file for the country your changes apply in `./data/countries/.yaml` for holiday data and/or `./data/names.yaml` for translations as appropriate -5. Generate the Json file from the yaml files with +5. Generate the new Json file from the yaml files with ``` npm run yaml ```