fix: prevent division by zero in quoteCollateral()#1105
Open
Kubudak90 wants to merge 1 commit into
Open
Conversation
1c14427 to
c174ec5
Compare
…-finance#1104 Apply two-layer protection against divide-by-zero: 1. Constructor: Change storeFrontPriceFactor validation from > to >= FACTOR_SCALE 2. Runtime: Add guard check for assetPriceDiscounted == 0 before division This prevents permanent disabling of collateral sales when: - storeFrontPriceFactor == FACTOR_SCALE (1e18) AND - liquidationFactor == 0 for any collateral asset
c174ec5 to
c306cf6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1104
Applies two-layer protection against divide-by-zero in quoteCollateral():
Problem
When storeFrontPriceFactor == FACTOR_SCALE (1e18) and liquidationFactor == 0:
This permanently disables collateral sales for that market since the config is immutable.
Solution
Two-layer defense:
Checklist
Testing
quoteCollateral()divides by zero whenstoreFrontPriceFactor == FACTOR_SCALEandliquidationFactor == 0#1104