fix: normalize address case in maybeStore function#1106
Open
Kubudak90 wants to merge 1 commit into
Open
Conversation
The maybeStore function in Spider.ts was comparing addresses case-sensitively when checking against constants.AddressZero. This could cause issues when addresses have different checksum casing (e.g., 0xA0b86... vs 0xa0b86...). This fix normalizes both addresses to lowercase before comparison, ensuring consistent behavior regardless of how the address was originally formatted. Fixes potential bug where an address stored with checksum casing wouldn't match against AddressZero, causing incorrect alias storage behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a case-sensitivity bug in the function in where addresses were compared without normalizing case.
Problem
The function was comparing addresses case-sensitively when checking against :
This could cause issues when:
Solution
Normalize both addresses to lowercase before comparison:
This ensures consistent behavior regardless of how the address was originally formatted.
Testing
Related
This follows the same defensive programming pattern used elsewhere in the codebase, such as in where addresses are normalized before comparison.