fix: normalize address keys to lowercase in relations config#1107
Open
Kubudak90 wants to merge 2 commits into
Open
fix: normalize address keys to lowercase in relations config#1107Kubudak90 wants to merge 2 commits into
Kubudak90 wants to merge 2 commits into
Conversation
added 2 commits
April 7, 2026 01:59
The maybeStore function in Spider.ts was comparing addresses case-sensitively when checking against constants.AddressZero. This could cause issues when addresses have different checksum casing (e.g., 0xA0b86... vs 0xa0b86...). This fix normalizes both addresses to lowercase before comparison, ensuring consistent behavior regardless of how the address was originally formatted. Fixes potential bug where an address stored with checksum casing wouldn't match against AddressZero, causing incorrect alias storage behavior.
Fixes compound-finance#765. Spider.ts expects address keys in relations.ts to be lowercase, but users may provide checksummed addresses. This change normalizes all address keys to lowercase in getRelationConfig() to ensure case-insensitive matching. The fix uses ethers.utils.isAddress() to detect address keys and converts them to lowercase while preserving non-address keys (like contract names).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #765. Spider.ts expects address keys in relations.ts to be lowercase, but users may provide checksummed addresses. This change normalizes all address keys to lowercase in getRelationConfig() to ensure case-insensitive matching.
The fix uses ethers.utils.isAddress() to detect address keys and converts them to lowercase while preserving non-address keys (like contract names).