fix: prevent division by zero in quoteCollateral#1111
Open
Kubudak90 wants to merge 1 commit into
Open
Conversation
- Change storeFrontPriceFactor check from > to >= FACTOR_SCALE to prevent discountFactor from reaching FACTOR_SCALE, which would make assetPriceDiscounted zero and cause division by zero downstream. - Add explicit zero-check on assetPriceDiscounted before it's used as a divisor in collateral asset quantity calculations. Fixes compound-finance#1104
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1104
This PR adds two defensive checks to prevent division by zero in the
quoteCollateralfunction:Changes
Tighten storeFrontPriceFactor validation in constructor (all three Comet variants):
> FACTOR_SCALEto>= FACTOR_SCALEstoreFrontPriceFactor == FACTOR_SCALE, thediscountFactorcan reachFACTOR_SCALE, causingassetPriceDiscountedto become zeroAdd zero-price guard in quoteCollateral (all three Comet variants):
if (assetPriceDiscounted == 0) revert BadPrice();before the discounted price is used as a divisorAffected contracts
contracts/Comet.solcontracts/CometWithExtendedAssetList.solcontracts/ScrollComet.sol