Update non-USD based Comets on Mainnet to the service patch version#1128
Open
MishaShWoof wants to merge 255 commits into
Open
Update non-USD based Comets on Mainnet to the service patch version#1128MishaShWoof wants to merge 255 commits into
MishaShWoof wants to merge 255 commits into
Conversation
…s for extended pause
…ltichain-proposal-simulation
…arios - Updated test suite descriptions for clarity on asset liquidation conditions. - Renamed variables to better reflect their purpose in the context of collateral factors. - Enhanced readability and understanding of test cases related to asset absorption and liquidation factors.
…actors-validation Fix: Price fetching for deactivated collaterals, optimized factors validation in AssetList + new tests
…actors-validation Test: improved test cases description in absorb tests, added new tests for zero factors cases
…nto woof-software/update-to-new-factory-non-usd
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+141
to
+142
| if (assetConfig.borrowCollateralFactor >= assetConfig.liquidateCollateralFactor && assetConfig.borrowCollateralFactor != 0) | ||
| revert CometMainInterface.BorrowCFTooLarge(); |
| // Be nice and check descaled values are still within range | ||
| if (borrowCollateralFactor >= liquidateCollateralFactor) revert CometMainInterface.BorrowCFTooLarge(); | ||
| // safety check duplicate sanity check on original values to ensure no values skewing after descaling and type conversion | ||
| if (borrowCollateralFactor >= liquidateCollateralFactor && borrowCollateralFactor != 0) revert CometMainInterface.BorrowCFTooLarge(); |
| */ | ||
| function pauseCollateralAssetSupply(uint24 assetIndex, bool paused) override external onlyGovernorOrPauseGuardian isValidAssetIndex(assetIndex) { | ||
| if ((collateralsSupplyPauseFlags & (uint24(1) << assetIndex) != 0) == paused) revert CollateralAssetOffsetStatusAlreadySet(collateralsSupplyPauseFlags, assetIndex, paused); | ||
| if (!paused && isCollateralDeactivated(assetIndex)) revert CollateralIsDeactivated(assetIndex); |
| */ | ||
| function pauseCollateralAssetTransfer(uint24 assetIndex, bool paused) override external onlyGovernorOrPauseGuardian isValidAssetIndex(assetIndex) { | ||
| if ((collateralsTransferPauseFlags & (uint24(1) << assetIndex) != 0) == paused) revert CollateralAssetOffsetStatusAlreadySet(collateralsTransferPauseFlags, assetIndex, paused); | ||
| if (!paused && isCollateralDeactivated(assetIndex)) revert CollateralIsDeactivated(assetIndex); |
There was a problem hiding this comment.
0xd8da6bf26964af9d7eed9e03e53415d37aa96045
…-software/comet into develop-tmp
…ftware/update-to-new-factory-non-usd
…f-software/update-to-new-factory-non-usd
…f-software/update-to-new-factory-non-usd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.