Specify package archive with `:ensure (t . pin)`

[toyboot4e]

Description

Like :pin in use-package, :ensure (t . pin) should pin a package to an archive. The syntax is ready, but the handler is not yet implemented.

Issue leaf-block

Example:

(leaf hoge
  :ensure (t . melpa-stable))

Expected output from macroexpand-1 of the leaf-block

The macro expansion seems like already OK:

(prog1 'hoge
  (leaf-handler-leaf-path hoge)
  (leaf-handler-leaf-protect hoge
      (leaf-handler-package hoge hoge melpa-stable)))

Just the implementations of leaf-handler-package and leaf-options-ensure-default-pin are lacking.

Related

• use-package-ensure-elpa in use-package could be seen as a reference implementation.

[toyboot4e]

No, the macro expansion should be like this, as in leaf-tests.el?

;; leaf block
(leaf hoge
  :ensure (t . melpa-stable))

;; expanded
(prog1 'hoge
  (leaf-handler-leaf-path hoge)
  (leaf-handler-leaf-protect hoge
-      (leaf-handler-package hoge hoge melpa-stable) (leaf-handler-package hoge hoge nil)))
+      (leaf-handler-package hoge hoge melpa-stable)))

Edit: Never mind, my setting was leaf-defaults with :ensure t.

[conao3]

Maybe we should implement this missing feature on leaf-handler-package, so we have to add testcase on this.

leaf.el/leaf-tests.el

Lines 2405 to 2431 in 466e12a

	(cort-deftest-with-macroexpand leaf/handler-package
	'(
	;; simple :ensure expandion example
	((leaf macrostep :ensure t)
	(prog1 'macrostep
	(leaf-handler-package macrostep macrostep nil)))
	;; `leaf-handler-package' expansion example.
	;; If `macrostep' is installed, set it as a selected package;
	;; otherwise try to install it.
	;; If installation fails, update local cache and retry to install.
	((leaf-handler-package macrostep macrostep nil)
	(progn
	(leaf-safe-push 'macrostep package-selected-packages 'no-dup)
	(unless (package-installed-p 'macrostep)
	(unless (assoc 'macrostep package-archive-contents)
	(package-refresh-contents))
	(condition-case _err
	(package-install 'macrostep)
	(error
	(package-refresh-contents)
	(condition-case err
	(package-install 'macrostep)
	(error
	(display-warning 'leaf
	(format "In `macrostep' block, failed to :package of `macrostep'. Error msg: %s"
	(error-message-string err))))))))))))