Bug: `approveAllowance` places the required `signTx` parameter after the defaulted `expirationLedger`, making the default unreachable

[Jaydbrown]

File: lib/tokens.ts:176-184 (approveAllowance)

export async function approveAllowance(
  source: string,
  tokenAddress: string,
  spender: string,
  amount: bigint,
  expirationLedger: number = DEFAULT_EXPIRATION_LEDGER,   // optional, has a default
  signTx: (xdr: string, signal?) => Promise<string>,      // REQUIRED, comes after
  options?: { signal?: AbortSignal },
): Promise<ApproveResult>

A required parameter (signTx) sits after a parameter with a default value
(expirationLedger). TypeScript still requires the caller to pass
expirationLedger positionally to reach signTx, so the default is unreachable
in practice — every call site must write
approveAllowance(src, tok, sp, amt, DEFAULT_EXPIRATION_LEDGER, signTx).

Suggested fix

Move signTx before expirationLedger, or take a single options object.

[oscar24357]

@oscar24357 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello boss good evening, can you please assign this issue to me? Thank you

ℹ️ Repo Maintainers: To accept this application, review their application or assign @oscar24357 to this issue.

[Ayfataan]

@Ayfataan has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I would like to work on this issue. I’ve gone through the project and carefully reviewed the issue itself, and I believe it’s something I can handle effectively. I’m confident in my ability to work on it, give it my best, and get it completed successfully. I’m ready to take on the task and deliver a solid result.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Ayfataan to this issue.

[Awosdot]

@Awosdot has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi maintainer, can i be assigned to fix this one?

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Awosdot to this issue.

[Prudentdev-xyz]

@Prudentdev-xyz has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I’d like to work on this issue because it aligns with my current learning and development goals, and I’m interested in making meaningful contributions to open source. I have experience with JavaScript, TypeScript, Git/GitHub, and blockchain development, and I’m comfortable learning and working through existing codebases. I’m ready to understand the project’s architecture, implement the solution, and contribute a well-tested and maintainable fix.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Prudentdev-xyz to this issue.

[drips-wave]

Congratulations, @Prudentdev-xyz! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @Prudentdev-xyz: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox!

@Prudentdev-xyz's PR #437 was approved and merged by @Jaydbrown.

🏆 @Prudentdev-xyz: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (35 total points). Track your full progress on GrantFox.

👏 Great work, @Prudentdev-xyz! Keep contributing to conduit-protocol.

[drips-wave]

This issue has been completed by @Prudentdev-xyz as part of the Stellar Wave Program's 8th Wave 🥳

😎 @Prudentdev-xyz: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.