Skip to content

Bug: npm ci fails on main — package-lock.json has a renamed git dep and npmmirror.com URLs, so all CI is red #404

Description

@Jaydbrown

What

npm ci fails in CI on every recent main commit (and locally), so the
Lint & typecheck and Unit tests jobs never get to run — every open PR
inherits a red "CI" check regardless of its contents.

Two independent problems in package-lock.json:

1. SDK git dependency points at a repo that no longer exists

"@conduit-protocol/sdk": "github:conduit-protocol/conduit-sdk",
...
"node_modules/@conduit-protocol/sdk": {
  "resolved": "git+ssh://git@github.com/conduit-protocol/conduit-sdk.git#f364474..."
}

conduit-protocol/conduit-sdk was renamed to conduit-protocol/streamFi-sdk.
The git+ssh:// form also can't authenticate on the CI runner even for a repo
that does exist.

2. ~30 packages resolved against a regional mirror

"resolved": "https://registry.npmmirror.com/geist/-/geist-1.7.2.tgz"
"resolved": "https://registry.npmmirror.com/next-themes/-/next-themes-0.4.6.tgz"
...

registry.npmmirror.com (an npm mirror) is baked into the lockfile from a
contributor's local environment. CI (and anyone outside that network) gets
ENOTFOUND registry.npmmirror.com.

Fix

Regenerate package-lock.json on main against registry.npmjs.org, with
the SDK dependency spec updated to the current repo — e.g.
github:conduit-protocol/streamFi-sdk (HTTPS, not git+ssh), or publish
@conduit-protocol/sdk to npm and depend on the version.

Add a CI guard (grep -q npmmirror package-lock.json && exit 1) so a
mirror-polluted lockfile can't merge again.

Impact

No app PR can pass CI until this is fixed. Blocks #403 and every other open PR.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave program

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions