quoting issues for environment variables passed from podman

[dustymabe]

I am seeing quoting issues for environment variables where newlines and quotes " are getting mangled somehow. See the output below.

[bound] -bash-5.3$ rpm -q podman crun crun-krun libkrun libkrunfw
podman-5.8.2-1.fc44.x86_64
crun-1.27.1-1.fc44.x86_64
crun-krun-1.27.1-1.fc44.x86_64
libkrun-1.17.4-1.fc44.x86_64
libkrunfw-5.3.0-1.fc44.x86_64
[bound] -bash-5.3$ podman pull --quiet quay.io/fedora/fedora:44
a01ae4eb9c82a895c1e10f58ff011a8dcfca2b68b88d44979871a73d40184f85
[bound] -bash-5.3$ 
[bound] -bash-5.3$ export JSON_VAR='
{
    "var": "value",
    "var2": "value2",
}'
[bound] -bash-5.3$ podman run -it --rm -e JSON_VAR quay.io/fedora/fedora:44 echo "$JSON_VAR"

{
    "var": "value",
    "var2": "value2",
}
[bound] -bash-5.3$ 
[bound] -bash-5.3$ podman run -it --rm --runtime=krun -e JSON_VAR quay.io/fedora/fedora:44 echo "$JSON_VAR"

n{
n    ""var"": ""value"",
n    ""var2"": ""value2"",
n}

[dustymabe]

I am working on a fix for this.

[jakecorrenti]

@dustymabe Can you try this with #670? It's fixed a couple of other parsing bugs and might take care of this as well

[dustymabe]

@jakecorrenti oh nice. I have to admit I'm a bit at my limit on being able to build all of this (I'm mostly doing downstream rpm rebuilds with added patches) so switching to rust is going to be more complicated than I'd really like to attempt. How about we do one of:

1. if you have an RPM lying around I'll give it a try
2. the reproducer above is dead simple if you know someone with a functioning system with WIP: Port the init binary code to Rust #670 already built

That being said, IIUC the rust work wouldn't land until 2.0 and maybe we want to fix it in the c code too?

[dustymabe]

Here's an attempt at a fix: #679

[jakecorrenti]

That being said, IIUC the rust work wouldn't land until 2.0 and maybe we want to fix it in the c code too?

We've "branched" for 2.0 already and have merged breaking changes into main. @slp can correct me if I'm wrong here, but at this point you'll have to wait for 2.0 regardless.

That being said, I was able to verify this works with the new Rust port in #670

❯ LD_LIBRARY_PATH=/usr/local/lib64 podman run --rm --runtime /usr/local/bin/krun -e JSON_VAR quay.io/fedora/fedora:44 echo "$JSON_VAR"

{
    "var": "value",
    "var2": "value2",
}

[mtjhrc]

I suppose we could merge this before #670.
But anyway I feel like we may need a diverging 1.18.x branch eventually for merging 1.18.x specific fixes (depends how many important bugs in 1.18.x are found).

[slp]

I suppose we could merge this before #670.

Yes, let's fix this for 1.18.

But anyway I feel like we may need a diverging 1.18.x branch eventually for merging 1.18.x specific fixes (depends how many important bugs in 1.18.x are found).

I'm going to create the stable-1.18 branch now with a PR with all the pending cherry picks. PRs fixing 1.18.x could created pointing there.