Feature/literal classes b node#134
Closed
prbblrypier wants to merge 3 commits into
Closed
Conversation
|
MaillPierre
reviewed
Apr 22, 2025
Contributor
There was a problem hiding this comment.
I worry that using java.util.concurrent.ThreadLocalRandom may cause problems when we implement multithreading. I suggest replacing the ID generation with a call of java.util.UUID.randomUUID().toString()
MaillPierre
requested changes
Apr 22, 2025
Contributor
MaillPierre
left a comment
MaillPierre
left a comment
There was a problem hiding this comment.
I only have on remark on the CoreseAdaptedValueFactory to be addressed, afterward, it can be merged
Contributor
|
Directly merge in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added BNode to the new API.
BNode is for blank Node