statements and converter fixes and tests#142
Merged
Merged
Conversation
|
MaillPierre
approved these changes
May 14, 2025
remiceres
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Summary:
Added the getCoreseNode method to CoreseBoolean:
Added a getCoreseNode() method to CoreseBoolean to return the corresponding Corese node for CoreseBoolean instances, ensuring consistency with the overall framework.
Added the createStatement method to CoreseAdaptedValueFactory:
The method is now available to create statements from the new API, simplifying the creation of statements (with or without a context) from the provided subject, predicate, and object values.
Added methods to convert Edge from the old API to Statement in the new API (and vice versa):
Added conversion methods to translate old API Edge objects into the new Statement structure (and vice versa).
Next Step: Add BlankNode Support to the convert Method