Skip to content

statements and converter fixes and tests#142

Merged
remiceres merged 1 commit into
feature/corese-nextfrom
feature/statement
May 14, 2025
Merged

statements and converter fixes and tests#142
remiceres merged 1 commit into
feature/corese-nextfrom
feature/statement

Conversation

@prbblrypier
Copy link
Copy Markdown
Contributor

Changes Summary:

Added the getCoreseNode method to CoreseBoolean:

Added a getCoreseNode() method to CoreseBoolean to return the corresponding Corese node for CoreseBoolean instances, ensuring consistency with the overall framework.

Added the createStatement method to CoreseAdaptedValueFactory:

The method is now available to create statements from the new API, simplifying the creation of statements (with or without a context) from the provided subject, predicate, and object values.

Added methods to convert Edge from the old API to Statement in the new API (and vice versa):

Added conversion methods to translate old API Edge objects into the new Statement structure (and vice versa).

Next Step: Add BlankNode Support to the convert Method

@prbblrypier prbblrypier added this to the V5.0.0a milestone May 14, 2025
@prbblrypier prbblrypier requested a review from remiceres May 14, 2025 07:48
@github-actions
Copy link
Copy Markdown

Overall Project 47.91% -0.08% 🍏
Files changed 51.16%

File Coverage
CoreseStatement.java 100% 🍏
CoreseBoolean.java 84.21% -3.16%
CoreseConverter.java 58.71% -41.29%
CoreseAdaptedValueFactory.java 55.04% -6.3%
AbstractStatement.java 2.56% -97.44%

@github-actions
Copy link
Copy Markdown

Test Results

486 tests  +7   486 ✅ +7   26s ⏱️ +2s
 26 suites +1     0 💤 ±0 
 26 files   +1     0 ❌ ±0 

Results for commit 6479ad7. ± Comparison against base commit e817a0d.

@remiceres remiceres merged commit 09f233e into feature/corese-next May 14, 2025
2 checks passed
@remiceres remiceres deleted the feature/statement branch May 14, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants