Skip to content

Feature/128 model implementation#153

Merged
MaillPierre merged 11 commits into
feature/corese-nextfrom
feature/128-model-implementation
May 28, 2025
Merged

Feature/128 model implementation#153
MaillPierre merged 11 commits into
feature/corese-nextfrom
feature/128-model-implementation

Conversation

@abdoun89
Copy link
Copy Markdown

No description provided.

prbblrypier and others added 10 commits April 17, 2025 12:09
- Added CoreseTyped class for handling typed literals, extending AbstractStringLiteral.
- Introduced AbstractBNode class for blank node representation in RDF graphs.
- Created NamespaceAware interface for models supporting RDF namespaces.
- Developed AbstractNamespace class as a base implementation for namespaces.
- Implemented ReadOnlyModel class to provide a read-only view of RDF models.
- Added CoreseModel class to manage RDF operations backed by Corese Graph.
- Introduced CoreseValueConverter for converting between Corese Nodes and RDF4J Values.
- Created EmptyModel class to block access to all statements, allowing only namespace operations.
- Developed FilteredModel class to provide filtered views over RDF models based on subject, predicate, object, and context.
@abdoun89 abdoun89 requested review from MaillPierre and remiceres May 26, 2025 15:07
@github-actions
Copy link
Copy Markdown

Overall Project 47.84% -0.57% 🍏
Files changed 38.99%

File Coverage
CoreseStatement.java 100% 🍏
ModelNamespace.java 100% 🍏
CoreseTyped.java 93.2% 🍏
CoreseLanguageTaggedStringLiteral.java 81.82% -1.52% 🍏
CoreseBoolean.java 81.63% -3.06%
CoreseBNode.java 78.38% -21.62% 🍏
CoreseValueConverter.java 58.48% -41.52%
CoreseAdaptedValueFactory.java 57.4% 🍏
CoreseDate.java 54.3% 🍏
CoreseDatetime.java 51.35% -5.41%
CoreseModel.java 48.68% -51.32%
AbstractModel.java 46.99% -53.01%
AbstractNamespace.java 37.5% -62.5%
AbstractBNode.java 22.58% -77.42%
ReadOnlyModel.java 15.28% -84.72%
FilteredModel.java 0%
EmptyModel.java 0%
InMemoryModel.java 0% -87.72%
NamespaceAware.java 0%
AbstractBNode.java 0%

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 26, 2025

Test Results

515 tests  +35   515 ✅ +35   28s ⏱️ +3s
 29 suites + 3     0 💤 ± 0 
 29 files   + 3     0 ❌ ± 0 

Results for commit bb06c36. ± Comparison against base commit f006b6f.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this class exists ?

import fr.inria.corese.core.next.api.Statement;
import fr.inria.corese.core.next.api.Value;
import fr.inria.corese.core.next.api.base.model.AbstractModel;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Class comment about how it is a filtered view on a Model that must give a restricted access to triples but modifying the FilteredModel must modify the Model

Copy link
Copy Markdown
Contributor

@MaillPierre MaillPierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just waiting for english comment then it's all good

@github-actions
Copy link
Copy Markdown

Overall Project 47.84% -0.57% 🍏
Files changed 38.99%

File Coverage
CoreseStatement.java 100% 🍏
ModelNamespace.java 100% 🍏
CoreseTyped.java 93.2% 🍏
CoreseLanguageTaggedStringLiteral.java 81.82% -1.52% 🍏
CoreseBoolean.java 81.63% -3.06%
CoreseBNode.java 78.38% -21.62% 🍏
CoreseValueConverter.java 58.48% -41.52%
CoreseAdaptedValueFactory.java 57.4% 🍏
CoreseDate.java 54.3% 🍏
CoreseDatetime.java 51.35% -5.41%
CoreseModel.java 48.68% -51.32%
AbstractModel.java 46.99% -53.01%
AbstractNamespace.java 37.5% -62.5%
AbstractBNode.java 22.58% -77.42%
ReadOnlyModel.java 15.28% -84.72%
FilteredModel.java 0%
EmptyModel.java 0%
InMemoryModel.java 0% -87.72%
NamespaceAware.java 0%
AbstractBNode.java 0%

@MaillPierre MaillPierre merged commit c4da02d into feature/corese-next May 28, 2025
2 checks passed
@MaillPierre MaillPierre deleted the feature/128-model-implementation branch June 4, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants