Feature/150 cleaning logging by abdoun89 · Pull Request #154 · corese-stack/corese-core

abdoun89 · 2025-05-28T12:19:16Z

No description provided.

github-actions · 2025-05-28T12:23:41Z

Overall Project	47.91% `-0.09%`	🍏
Files changed	11.38%	❌

File	Coverage
Processor.java	89.4% `-0.7%`	❌
Aggregate.java	84.29% `-2.09%`	❌
Transformer.java	75.75% `-0.14%`	❌
RuleEngine.java	71.25% `-0.18%`	❌
PathFinder.java	69.36%	🍏
XMLResult.java	69.14% `-0.49%`	❌
Term.java	66.41% `-0.27%`	❌
Query.java	66.15%	🍏
Reduce.java	64.8%	🍏
UserImpl.java	63.87% `-2.58%`	❌
QuerySolverVisitorRule.java	63.54% `-1.1%`	❌
Access.java	63.53%	🍏
Transformer.java	62.71% `-0.17%`	❌
Filter.java	60.4%	🍏
XMLResult.java	56.61% `-0.41%`	❌
RuleLoad.java	55.33% `-0.74%`	❌
RDFaLoader.java	47.89% `-5.63%`	❌
LoadTurtle.java	46.94% `-4.08%`	❌
ResultFormater.java	45.65% `-2.9%`	❌
DefaultVisitor.java	44.99% `-0.89%`	❌
JsonldLoader.java	44.78% `-5.97%`	❌
Exp.java	40.1% `-0.49%`	❌
QueryLoad.java	35.74% `-0.83%`	❌
Expression.java	35.56%	🍏
MapAnyEvery.java	34.13%	🍏
QuerySolverVisitorTransformer.java	28.21% `-3.42%`	❌
BasicGraphPattern.java	22.9%	🍏
JavaDScall.java	22.22% `-4.44%`	❌
ListSort.java	15.34%	🍏
URLServer.java	14.69% `-0.46%`	❌
Javacall.java	6.75% `-1.69%`	❌
ClassHierarchy.java	0% `-13.46%`	❌
XSLTQuery.java	0% `-9.58%`	❌
Data.java	0% `-1.67%`	❌
Core.java	0% `-4.1%`	❌
Agent.java	0% `-6.09%`	❌
EventLogger.java	0% `-3.46%`	❌
LinkedDataPath.java	0% `-0.8%`	❌
QueryProcessThread.java	0% `-13.56%`	❌
Result.java	0% `-1.05%`	❌
ASTSelector.java	0% `-0.49%`	❌
SQLFun.java	0% `-32.99%`	❌

github-actions · 2025-05-28T12:23:59Z

Test Results

516 tests ±0 516 ✅ ±0 28s ⏱️ -1s
29 suites ±0 0 💤 ±0
29 files ±0 0 ❌ ±0

Results for commit 59c58a6. ± Comparison against base commit 09eb649.

♻️ This comment has been updated with latest results.

github-actions · 2025-06-10T07:20:28Z

Overall Project	47.85% `-0.09%`	🍏
Files changed	11.38%	❌

File	Coverage
Processor.java	89.4% `-0.7%`	❌
Aggregate.java	84.29% `-2.09%`	❌
Transformer.java	75.75% `-0.14%`	❌
RuleEngine.java	71.25% `-0.18%`	❌
PathFinder.java	69.36%	🍏
XMLResult.java	69.14% `-0.49%`	❌
Term.java	66.41% `-0.27%`	❌
Query.java	66.15%	🍏
Reduce.java	64.8%	🍏
UserImpl.java	63.87% `-2.58%`	❌
QuerySolverVisitorRule.java	63.54% `-1.1%`	❌
Access.java	63.53%	🍏
Transformer.java	62.71% `-0.17%`	❌
Filter.java	60.4%	🍏
XMLResult.java	56.61% `-0.41%`	❌
RuleLoad.java	55.33% `-0.74%`	❌
RDFaLoader.java	47.89% `-5.63%`	❌
LoadTurtle.java	46.94% `-4.08%`	❌
ResultFormater.java	45.65% `-2.9%`	❌
DefaultVisitor.java	44.99% `-0.89%`	❌
JsonldLoader.java	44.78% `-5.97%`	❌
Exp.java	40.1% `-0.49%`	❌
QueryLoad.java	35.74% `-0.83%`	❌
Expression.java	35.56%	🍏
MapAnyEvery.java	34.13%	🍏
QuerySolverVisitorTransformer.java	28.21% `-3.42%`	❌
BasicGraphPattern.java	22.9%	🍏
JavaDScall.java	22.22% `-4.44%`	❌
ListSort.java	15.34%	🍏
URLServer.java	14.69% `-0.46%`	❌
Javacall.java	6.75% `-1.69%`	❌
ClassHierarchy.java	0% `-13.46%`	❌
XSLTQuery.java	0% `-9.58%`	❌
Data.java	0% `-1.67%`	❌
Core.java	0% `-4.1%`	❌
Agent.java	0% `-6.09%`	❌
EventLogger.java	0% `-3.46%`	❌
LinkedDataPath.java	0% `-0.8%`	❌
QueryProcessThread.java	0% `-13.56%`	❌
Result.java	0% `-1.05%`	❌
ASTSelector.java	0% `-0.49%`	❌
SQLFun.java	0% `-32.99%`	❌

github-actions · 2025-06-10T12:35:33Z

Overall Project	47.65% `-0.09%`	🍏
Files changed	11.38%	❌

File	Coverage
Processor.java	89.4% `-0.7%`	❌
Aggregate.java	84.29% `-2.09%`	❌
Transformer.java	75.75% `-0.14%`	❌
RuleEngine.java	71.35% `-0.18%`	❌
PathFinder.java	69.36%	🍏
Term.java	66.41% `-0.27%`	❌
Query.java	66.15%	🍏
Reduce.java	64.8%	🍏
UserImpl.java	63.87% `-2.58%`	❌
QuerySolverVisitorRule.java	63.54% `-1.1%`	❌
Access.java	63.53%	🍏
Transformer.java	62.71% `-0.17%`	❌
Filter.java	60.4%	🍏
XMLResult.java	56.61% `-0.41%`	❌
RuleLoad.java	55.33% `-0.74%`	❌
RDFaLoader.java	47.89% `-5.63%`	❌
LoadTurtle.java	46.94% `-4.08%`	❌
ResultFormater.java	45.65% `-2.9%`	❌
DefaultVisitor.java	44.99% `-0.89%`	❌
JsonldLoader.java	44.78% `-5.97%`	❌
Exp.java	40.1% `-0.49%`	❌
QueryLoad.java	35.74% `-0.83%`	❌
Expression.java	35.56%	🍏
MapAnyEvery.java	34.13%	🍏
QuerySolverVisitorTransformer.java	28.21% `-3.42%`	❌
BasicGraphPattern.java	22.9%	🍏
JavaDScall.java	22.22% `-4.44%`	❌
ListSort.java	15.34%	🍏
URLServer.java	14.69% `-0.46%`	❌
Javacall.java	6.75% `-1.69%`	❌
ClassHierarchy.java	0% `-13.46%`	❌
XSLTQuery.java	0% `-9.58%`	❌
Data.java	0% `-1.67%`	❌
Core.java	0% `-4.1%`	❌
Agent.java	0% `-6.09%`	❌
EventLogger.java	0% `-3.46%`	❌
LinkedDataPath.java	0% `-0.8%`	❌
QueryProcessThread.java	0% `-13.56%`	❌
Result.java	0% `-1.05%`	❌
ASTSelector.java	0% `-0.49%`	❌
XMLResult.java	0% `-0.49%`	❌
SQLFun.java	0% `-32.99%`	❌

- Updated error messages from French to English across multiple classes to improve consistency and readability. - Changed "Une erreur inattendue est survenue" to "An unexpected error has occurred". - Changed "Échec de l'opération" to "Operation failure". - Changed "Une erreur s'est produite" to "An error has occurred".

remiceres

Good work! Everything is functioning as expected. I've made a few minor improvements:

Language Consistency: Some comments and messages were written in French. Please make sure to use English in all future contributions to maintain clarity and consistency throughout the project.
Redundant Logging Dependency: I removed runtimeOnly("org.slf4j:slf4j-simple:2.0.9"), which was no longer necessary after integrating Log4j2. Keeping only one logging backend avoids conflicts and ensures cleaner runtime behavior.
Logging Documentation: Great initiative on drafting a note to document the logging setup. However, I’ve migrated the content to the corese-docs repository. Internal "notes" are considered temporary and may be automatically deleted after a period of inactivity. Moving this documentation ensures it remains accessible, versioned, and properly maintained over time.

github-actions · 2025-06-10T13:12:34Z

Overall Project	47.65% `-0.09%`	🍏
Files changed	11.38%	❌

File	Coverage
Processor.java	89.4% `-0.7%`	❌
Aggregate.java	84.29% `-2.09%`	❌
Transformer.java	75.75% `-0.14%`	❌
RuleEngine.java	71.35% `-0.18%`	❌
PathFinder.java	69.36%	🍏
Term.java	66.41% `-0.27%`	❌
Query.java	66.15%	🍏
Reduce.java	64.8%	🍏
UserImpl.java	63.87% `-2.58%`	❌
QuerySolverVisitorRule.java	63.54% `-1.1%`	❌
Access.java	63.53%	🍏
Transformer.java	62.71% `-0.17%`	❌
Filter.java	60.4%	🍏
XMLResult.java	56.61% `-0.41%`	❌
RuleLoad.java	55.33% `-0.74%`	❌
RDFaLoader.java	47.89% `-5.63%`	❌
LoadTurtle.java	46.94% `-4.08%`	❌
ResultFormater.java	45.65% `-2.9%`	❌
DefaultVisitor.java	44.99% `-0.89%`	❌
JsonldLoader.java	44.78% `-5.97%`	❌
Exp.java	40.1% `-0.49%`	❌
QueryLoad.java	35.74% `-0.83%`	❌
Expression.java	35.56%	🍏
MapAnyEvery.java	34.13%	🍏
QuerySolverVisitorTransformer.java	28.21% `-3.42%`	❌
BasicGraphPattern.java	22.9%	🍏
JavaDScall.java	22.22% `-4.44%`	❌
ListSort.java	15.34%	🍏
URLServer.java	14.69% `-0.46%`	❌
Javacall.java	6.75% `-1.69%`	❌
ClassHierarchy.java	0% `-13.46%`	❌
XSLTQuery.java	0% `-9.58%`	❌
Data.java	0% `-1.67%`	❌
Core.java	0% `-4.1%`	❌
Agent.java	0% `-6.09%`	❌
EventLogger.java	0% `-3.46%`	❌
LinkedDataPath.java	0% `-0.8%`	❌
QueryProcessThread.java	0% `-13.56%`	❌
Result.java	0% `-1.05%`	❌
ASTSelector.java	0% `-0.49%`	❌
XMLResult.java	0% `-0.49%`	❌
SQLFun.java	0% `-32.99%`	❌

abdoun89 requested a review from MaillPierre May 28, 2025 12:19

abdessamad-abdoun force-pushed the feature/150-Cleaning-logging branch from 9535f57 to 38f2401 Compare June 10, 2025 07:17

remiceres added the Refactoring Issue created during the 2025 refactoring effort label Jun 10, 2025

remiceres self-requested a review June 10, 2025 09:28

abdounabdessamad-tech and others added 8 commits June 10, 2025 14:51

150 - Cleaning and refactoring of the logging system

70ebb31

#150 - Cleaning and refactoring of the logging system

75fba4a

#150 - Cleaning and refactoring of the logging system

23fdc16

#150 - Cleaning and refactoring of the logging system

ff8cab3

#150 - Cleaning and refactoring of the logging system

75003f6

Refactor dependency declarations for clarity and organization

e1b38f6

Remove logging strategy section from README

59c58a6

remiceres force-pushed the feature/150-Cleaning-logging branch from 463782d to 59c58a6 Compare June 10, 2025 13:02

remiceres approved these changes Jun 10, 2025

View reviewed changes

remiceres merged commit 0bb36f0 into feature/corese-next Jun 10, 2025
2 checks passed

remiceres deleted the feature/150-Cleaning-logging branch June 10, 2025 13:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/150 cleaning logging#154

Feature/150 cleaning logging#154
remiceres merged 8 commits into
feature/corese-nextfrom
feature/150-Cleaning-logging

abdoun89 commented May 28, 2025

Uh oh!

github-actions Bot commented May 28, 2025

Uh oh!

github-actions Bot commented May 28, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 10, 2025

Uh oh!

github-actions Bot commented Jun 10, 2025

Uh oh!

remiceres left a comment

Uh oh!

github-actions Bot commented Jun 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

abdoun89 commented May 28, 2025

Uh oh!

github-actions Bot commented May 28, 2025

Uh oh!

github-actions Bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions Bot commented Jun 10, 2025

Uh oh!

github-actions Bot commented Jun 10, 2025

Uh oh!

remiceres left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented May 28, 2025 •

edited

Loading