Skip to content

rewrite "a" to rdf:type URI#450

Merged
MaillPierre merged 2 commits into
feature/corese-nextfrom
feature/435-sparql11-fix-shortcut-a-in-sparql-queries-to-be-resolved-as-an-iriast-containing-the-rdftype-uri
May 20, 2026
Merged

rewrite "a" to rdf:type URI#450
MaillPierre merged 2 commits into
feature/corese-nextfrom
feature/435-sparql11-fix-shortcut-a-in-sparql-queries-to-be-resolved-as-an-iriast-containing-the-rdftype-uri

Conversation

@MaillPierre
Copy link
Copy Markdown
Contributor

Just replace "a" with the rdf:type URI

@MaillPierre MaillPierre self-assigned this May 19, 2026
@MaillPierre MaillPierre added the Refactoring Issue created during the 2025 refactoring effort label May 19, 2026
@github-actions
Copy link
Copy Markdown

Overall Project 48.97% 🍏
Files changed 100% 🍏

File Coverage
SparqlAstBuilder.java 84.52% 🍏

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

Test Results

  408 files  ±0    408 suites  ±0   20s ⏱️ -3s
2 236 tests ±0  2 236 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 250 runs  ±0  2 250 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f2066dc. ± Comparison against base commit e4684ae.

♻️ This comment has been updated with latest results.

*/
public TermAst iri(String raw) {
if (raw == null) throw new IllegalArgumentException("IRI raw is null");
if(raw.equals("a")) return new IriAst("<" + RDF.type.getIRI().stringValue() + ">");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a static method that create and return return new IriAst("<" + RDF.type.getIRI().stringValue() + ">")

@github-actions
Copy link
Copy Markdown

Overall Project 48.97% 🍏
Files changed 100% 🍏

File Coverage
SparqlAstBuilder.java 84.52% 🍏

Copy link
Copy Markdown
Contributor

@prbblrypier prbblrypier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a helper method to create the IRI of a. If it's ok for every one we can merge

@MaillPierre MaillPierre force-pushed the feature/435-sparql11-fix-shortcut-a-in-sparql-queries-to-be-resolved-as-an-iriast-containing-the-rdftype-uri branch from 765f8af to f2066dc Compare May 20, 2026 08:38
@github-actions
Copy link
Copy Markdown

Overall Project 48.97% 🍏
Files changed 100% 🍏

File Coverage
SparqlAstBuilder.java 84.3% 🍏

@MaillPierre MaillPierre merged commit 1259e04 into feature/corese-next May 20, 2026
2 checks passed
@MaillPierre MaillPierre deleted the feature/435-sparql11-fix-shortcut-a-in-sparql-queries-to-be-resolved-as-an-iriast-containing-the-rdftype-uri branch May 20, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactoring Issue created during the 2025 refactoring effort

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SPARQL1.1] Fix shortcut "a" in SPARQL queries to be resolved as an IriAst containing the RDF:type URI

2 participants