Actions: Add checks to ensure clean extension build files

Author: cpiber

.github/workflows/node.js.yml

@@ -34,11 +34,48 @@ jobs:
         npm run env | grep npm_package_version >> $GITHUB_ENV
     - run: |
         echo Workflow triggered by event ${{ github.event_name }}
+    - name: Install grep and find
+      run: sudo apt-get install grep findutils
+    
+    - name: Create non-minified js files
+      run: npm run build:js -- --environment NO_MINIFY
+      env:
+        YT_API_KEY: ${{ secrets.YOUTUBE_KEY }}
+    - name: Verify no debug artifacts
+      run: |
+        dev=$(grep --color=always "devClone\|devExport\|(()=>{})" $(find extension-dist -name "*.js") || echo "")
+        if [ -n "$dev" ]; then
+          echo "::group::Invalid statements"
+          echo "$dev"
+          echo "::endgroup::"
+          echo "::error ::Found statements that shouldn't be in the production build!"
+          exit 1
+        fi
+      shell: bash
 
     - name: Build
       run: npm run build:all # does not run tests
       env:
         YT_API_KEY: ${{ secrets.YOUTUBE_KEY }}
+    
+    - name: Verify directory structure
+      run: |
+        locales=$(find extension-dist/_locales -not -name "*.json" -type f)
+        scripts=$(find extension-dist/scripts -not -name "*.js" -type f)
+        styles=$(find extension-dist/styles -not -name "*.css" -type f)
+        if [ -n "$locales" ] || [ -n "$scripts" ] || [ -n "$styles" ]; then
+          echo "::group::Files found"
+          echo -e "\nIn _locales"
+          echo "$locales"
+          echo -e "\nIn scripts"
+          echo "$scripts"
+          echo -e "\nIn styles"
+          echo "$styles"
+          echo "::endgroup::"
+          echo "::error ::Found files that do not belong!"
+          exit 1
+        fi
+      shell: bash
 
     - name: Archive extension
       uses: actions/upload-artifact@v2

rollup.config.js

@@ -40,10 +40,10 @@ const question = q => new Promise(resolve => readline.question(q, answer => reso
 const jsreplace = (dev = !process.env.BUILD) => ({
   '__YT_API_KEY__': JSON.stringify(process.env.YT_API_KEY),
   '__DEV__': JSON.stringify(dev),
-  'console.dev.log': dev ? 'console.log' : 'void',
-  'console.dev.debug': dev ? 'console.debug' : 'void',
-  'console.dev.warn': dev ? 'console.warn' : 'void',
-  'console.dev.error': dev ? 'console.error' : 'void',
+  'console.dev.log': dev ? 'console.log' : '(()=>{})',
+  'console.dev.debug': dev ? 'console.debug' : '(()=>{})',
+  'console.dev.warn': dev ? 'console.warn' : '(()=>{})',
+  'console.dev.error': dev ? 'console.error' : '(()=>{})',
   'preventAssignment': true,
 });
 const jsplugins = () => [
@@ -206,7 +206,8 @@ function remove() {
         if (!bundle[prop].code) continue;
         if (bundle[prop].code === '\n' ||
           bundle[prop].code.trim() === 'var undefined$1 = undefined;\n\nexport default undefined$1;' ||
-          bundle[prop].code.trim() === 'var undefined$1 = undefined;\n\nexport { undefined$1 as default };')
+          bundle[prop].code.trim() === 'var undefined$1 = undefined;\n\nexport { undefined$1 as default };'
+        )
           delete bundle[prop];
       }
     },