From 5c247db3f36b122e32778e4354e03d798a1ace29 Mon Sep 17 00:00:00 2001 From: kwood <155027796+qkewq@users.noreply.github.com> Date: Wed, 29 Jul 2026 09:40:34 -0700 Subject: [PATCH 1/3] Update pools.go Change pools endpoint to new format --- internal/proxmox/pools.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/proxmox/pools.go b/internal/proxmox/pools.go index 69f1259..2b27ac6 100644 --- a/internal/proxmox/pools.go +++ b/internal/proxmox/pools.go @@ -16,7 +16,7 @@ import ( func (s *ProxmoxService) GetPoolVMs(poolName string) ([]VirtualResource, error) { req := tools.ProxmoxAPIRequest{ Method: "GET", - Endpoint: fmt.Sprintf("/pools/%s", poolName), + Endpoint: fmt.Sprintf("/pools/?poolid=%s", poolName), } var poolResponse struct { @@ -92,7 +92,7 @@ func (s *ProxmoxService) SetPoolPermission(poolName string, targetName string, i func (s *ProxmoxService) DeletePool(poolName string) error { req := tools.ProxmoxAPIRequest{ Method: "DELETE", - Endpoint: fmt.Sprintf("/pools/%s", poolName), + Endpoint: fmt.Sprintf("/pools/?poolid=%s", poolName), } _, err := s.RequestHelper.MakeRequest(req) From 1f13c5d4bf5cf860419b69ed1080d4fa45daf926 Mon Sep 17 00:00:00 2001 From: kwood <155027796+qkewq@users.noreply.github.com> Date: Wed, 29 Jul 2026 10:28:39 -0700 Subject: [PATCH 2/3] Update pools.go Change to match data returned by new pools endpoint --- internal/proxmox/pools.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/internal/proxmox/pools.go b/internal/proxmox/pools.go index 2b27ac6..9c3e50e 100644 --- a/internal/proxmox/pools.go +++ b/internal/proxmox/pools.go @@ -20,7 +20,9 @@ func (s *ProxmoxService) GetPoolVMs(poolName string) ([]VirtualResource, error) } var poolResponse struct { - Members []VirtualResource `json:"members"` + Data []struct { + Members []VirtualResource `json:"members"` + }`json:"data"` } if err := s.RequestHelper.MakeRequestAndUnmarshal(req, &poolResponse); err != nil { return nil, fmt.Errorf("failed to get pool VMs: %w", err) @@ -28,7 +30,7 @@ func (s *ProxmoxService) GetPoolVMs(poolName string) ([]VirtualResource, error) // Filter for VMs only (type=qemu) var vms []VirtualResource - for _, member := range poolResponse.Members { + for _, member := range poolResponse.Data[0].Members { if member.Type == "qemu" { vms = append(vms, member) } From 9d3adda4f82e8d32e4441fa0703d72ffe22e44ed Mon Sep 17 00:00:00 2001 From: kwood <155027796+qkewq@users.noreply.github.com> Date: Wed, 29 Jul 2026 11:01:57 -0700 Subject: [PATCH 3/3] Update pools.go Fixed pools unmarshaled data type --- internal/proxmox/pools.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/internal/proxmox/pools.go b/internal/proxmox/pools.go index 9c3e50e..6df717e 100644 --- a/internal/proxmox/pools.go +++ b/internal/proxmox/pools.go @@ -19,10 +19,8 @@ func (s *ProxmoxService) GetPoolVMs(poolName string) ([]VirtualResource, error) Endpoint: fmt.Sprintf("/pools/?poolid=%s", poolName), } - var poolResponse struct { - Data []struct { - Members []VirtualResource `json:"members"` - }`json:"data"` + var poolResponse []struct { + Members []VirtualResource `json:"members"` } if err := s.RequestHelper.MakeRequestAndUnmarshal(req, &poolResponse); err != nil { return nil, fmt.Errorf("failed to get pool VMs: %w", err) @@ -30,7 +28,7 @@ func (s *ProxmoxService) GetPoolVMs(poolName string) ([]VirtualResource, error) // Filter for VMs only (type=qemu) var vms []VirtualResource - for _, member := range poolResponse.Data[0].Members { + for _, member := range poolResponse[0].Members { if member.Type == "qemu" { vms = append(vms, member) }