Skip to content

Add CODEOWNERS and document the review expectations #336

Description

@Otaiki1

Context

The repo spans four expertise areas that barely overlap: circom/ZK, Rust/Soroban, TypeScript SDK, and
React/a11y. A circuit change reviewed by someone who does not read circom is a rubber stamp, and with
no CI in this repo, human review is the gate.

CONTRIBUTING.md documents the label taxonomy and triage flow but not who reviews what.

Where to build it

  • New file .github/CODEOWNERS.
  • CONTRIBUTING.md — a "Review expectations" section.

What to do

  • Map paths to owners: circuits/** and contracts/** are the security-critical ones and should require a domain reviewer.
  • State plainly in CONTRIBUTING.md that, because there is no CI, the reviewer is responsible for confirming just verify passed on the merge result — the merge-regression issue explains why this matters.
  • Call out the wire-format boundary: any PR touching circuit public signals, contract public_inputs, or SDK encoding needs review on all three sides.

Acceptance criteria

  • Every top-level directory has an owner.
  • The no-CI review responsibility is written down.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Stellar WaveIssues in the Stellar wave programdocumentationImprovements or additions to documentationdxDeveloper experience & toolinggood first issueGood for newcomers

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions