From 432dd285cf5a42ba8998d44d05f1af8a48a3f326 Mon Sep 17 00:00:00 2001
From: ChrisLi <chris.li@senao.com>
Date: Fri, 8 May 2026 12:06:46 +0800
Subject: [PATCH 1/2] feat: cycle tabs with Ctrl+PageUp / Ctrl+PageDown

Mirror the existing Shift+ArrowUp/Down handler so the more
conventional Ctrl+PageUp/PageDown also switches tabs. Same
guards: capture phase, skipped in passthrough mode and when
focus is in a real text input.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---
 src/App.tsx | 25 ++++++++++++++++---------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/src/App.tsx b/src/App.tsx
index 6680c17..d55f58c 100644
--- a/src/App.tsx
+++ b/src/App.tsx
@@ -119,17 +119,23 @@ export default function App() {
 
     window.addEventListener("beforeunload", () => flushPersistedState());
 
-    // Shift+ArrowUp / Shift+ArrowDown: cycle tabs. Registered in the capture
-    // phase so it fires before xterm's textarea handler — otherwise xterm
-    // swallows the event (translates it to a PTY escape sequence) and the tab
-    // bar only responds after the user clicks the sidebar to move focus.
-    // Skipped when focus is in a real text input / passthrough mode so the key
-    // can still extend selection / be forwarded to the remote agent.
+    // Shift+ArrowUp/Down and Ctrl+PageUp/PageDown: cycle tabs. Registered in
+    // the capture phase so it fires before xterm's textarea handler —
+    // otherwise xterm swallows the event (translates it to a PTY escape
+    // sequence) and the tab bar only responds after the user clicks the
+    // sidebar to move focus. Skipped when focus is in a real text input /
+    // passthrough mode so the key can still extend selection / be forwarded
+    // to the remote agent.
     window.addEventListener(
       "keydown",
       (e) => {
-        if (!e.shiftKey || e.ctrlKey || e.altKey || e.metaKey) return;
-        if (e.key !== "ArrowUp" && e.key !== "ArrowDown") return;
+        const shiftCombo =
+          e.shiftKey && !e.ctrlKey && !e.altKey && !e.metaKey &&
+          (e.key === "ArrowUp" || e.key === "ArrowDown");
+        const ctrlCombo =
+          e.ctrlKey && !e.shiftKey && !e.altKey && !e.metaKey &&
+          (e.key === "PageUp" || e.key === "PageDown");
+        if (!shiftCombo && !ctrlCombo) return;
         if (isActiveTabPassthrough()) return;
         // xterm's own input is a hidden <textarea>, so we can't blanket-skip
         // text inputs — instead, allow if focus is inside an .xterm container,
@@ -143,8 +149,9 @@ export default function App() {
         if (list.length < 2) return;
         e.preventDefault();
         e.stopPropagation();
+        const goPrev = e.key === "ArrowUp" || e.key === "PageUp";
         const idx = list.findIndex((t) => t.id === activeTabId());
-        const next = e.key === "ArrowUp"
+        const next = goPrev
           ? (idx - 1 + list.length) % list.length
           : (idx + 1) % list.length;
         setActiveTab(list[next].id);

From c49a98dbb2c9e7833c640678334db53305142d9b Mon Sep 17 00:00:00 2001
From: ChrisLi <chris.li@senao.com>
Date: Fri, 8 May 2026 12:06:46 +0800
Subject: [PATCH 2/2] fix: stop double-paste on middle-click
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

We were both calling navigator.clipboard.readText() + sshWrite on
mousedown AND letting WebKitGTK do its native primary-selection
paste into the focused textarea, so the same text reached the PTY
twice. Drop the manual readText path and keep only preventDefault
on middle-click to suppress the browser's auto-scroll affordance —
the native paste flows through xterm's onData handler exactly once.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---
 src/components/SideTerminal.tsx | 11 ++++-------
 src/components/Terminal.tsx     | 15 ++++-----------
 2 files changed, 8 insertions(+), 18 deletions(-)

diff --git a/src/components/SideTerminal.tsx b/src/components/SideTerminal.tsx
index 7fc732e..5bbe6cc 100644
--- a/src/components/SideTerminal.tsx
+++ b/src/components/SideTerminal.tsx
@@ -259,16 +259,13 @@ function SideTerminalView(props: { sessionId: string; parentTabId: string }) {
     };
     host.addEventListener("mouseup", onMouseUp);
 
-    // Middle-click paste (X11-style): write clipboard text straight to the PTY.
+    // Middle-click: just suppress the browser's auto-scroll affordance.
+    // WebKitGTK already does X11-style primary-selection paste into the
+    // focused textarea, which xterm forwards via onData — doing our own
+    // clipboard.readText + sshWrite here would paste twice.
     const onMouseDown = (e: MouseEvent) => {
       if (e.button !== 1) return;
       e.preventDefault();
-      navigator.clipboard
-        .readText()
-        .then((text) => {
-          if (text) api.sshWrite(props.sessionId, text).catch(console.error);
-        })
-        .catch((err) => console.warn("clipboard read failed", err));
     };
     host.addEventListener("mousedown", onMouseDown);
 
diff --git a/src/components/Terminal.tsx b/src/components/Terminal.tsx
index 18b5a9e..0cf1dd2 100644
--- a/src/components/Terminal.tsx
+++ b/src/components/Terminal.tsx
@@ -237,20 +237,13 @@ export function TerminalView(props: Props) {
     host.addEventListener("mouseup", onMouseUp);
     onCleanup(() => host.removeEventListener("mouseup", onMouseUp));
 
-    // Middle-click pastes plain text from the OS clipboard (X11-style). We
-    // intercept on mousedown to suppress the browser's auto-scroll affordance,
-    // then write the text directly to the PTY.
+    // Middle-click: just suppress the browser's auto-scroll affordance.
+    // WebKitGTK already does X11-style primary-selection paste into the
+    // focused textarea, which xterm forwards via onData — doing our own
+    // clipboard.readText + sshWrite here would paste twice.
     const onMouseDown = (e: MouseEvent) => {
       if (e.button !== 1) return;
       e.preventDefault();
-      navigator.clipboard
-        .readText()
-        .then((text) => {
-          if (!text) return;
-          const sid = props.tab.sessionId;
-          if (sid) api.sshWrite(sid, text).catch(console.error);
-        })
-        .catch((err) => console.warn("clipboard read failed", err));
     };
     host.addEventListener("mousedown", onMouseDown);
     onCleanup(() => host.removeEventListener("mousedown", onMouseDown));