M1I05: SocketProxyInterface + ReusePortProxy

[s2x]

Summary

File	Action
src/Server/Socket/SocketProxyInterface.php	Create — interface with createSocket(), accept(), isSupported()
src/Server/Socket/ReusePortProxy.php	Create — SO_REUSEADDR + SO_REUSEPORT proxy
tests/Server/Socket/ReusePortProxyTest.php	Create — unit tests

Acceptance criteria

• SocketProxyInterface defines 3 methods with correct signatures
• ReusePortProxy implements the interface, uses SO_REUSEADDR + conditional SO_REUSEPORT
• isSupported() returns false on Windows or when constant undefined
• Tests pass (or skip on unsupported platforms)

Closes #7

[s2x]

Review Summary — Round 1

#	Severity	File:Line	Finding
1	MEDIUM	ReusePortProxyTest.php:27	Unnecessary skip in testCreateSocketReturnsSocket
2	LOW	ReusePortProxyTest.php:42	Unnecessary skip in testAcceptReturnsConnection

Follow-up Observations

• Unused $protocol parameter: ReusePortProxy::createSocket() accepts ProtocolType $protocol but always creates AF_INET, SOCK_STREAM, SOL_TCP sockets regardless. Functionally correct for current types (TCP, HTTP, WS all run over TCP), but a future non-TCP protocol would silently get wrong socket type. Consider @param docs or a match on protocol.
• 0.0.0.0 for client connect: testAcceptReturnsConnection connects to $address from socket_getsockname which returns 0.0.0.0. Existing tests (e.g., SocketTest) bind to 127.0.0.1 explicitly. Consider binding to 127.0.0.1 in the proxy or overriding in the test for consistency.
• No error-path tests: No test covers the SocketCreationException path (e.g., when socket_create fails).

What's Fine ✔️

• Interface signatures match spec exactly
• isSupported() implementation matches spec (defined('SO_REUSEPORT') && PHP_OS_FAMILY !== 'Windows')
• Conditional SO_REUSEPORT logic is correct
• Test covers interface implementation, socket creation, accept, and isSupported
• No security issues (no secrets, PII, injection vectors)
• All acceptance criteria from issue #7 and milestone doc satisfied

[s2x]

Review Summary — Round 2

#	Severity	Status	Finding
1	MEDIUM	✅ Fixed	testCreateSocketReturnsSocket had unnecessary isSupported() skip
2	LOW	✅ Fixed	testAcceptReturnsConnection had same unnecessary skip

Follow-up Observations

• $protocol param unused in createSocket — always creates TCP sockets. When HTTP/WebSocket support is added to proxy implementations, this parameter will be used for protocol-specific socket creation.
• Reflection helper — getSocketResource() could be extracted to a test trait if similar helpers are needed in other proxy tests.

What's Fine ✅

• All 4 CI checks pass (lint + tests on PHP 8.2–8.5)
• Interface signatures match spec exactly: createSocket(), accept(), isSupported()
• ReusePortProxy implements SO_REUSEADDR + conditional SO_REUSEPORT correctly
• isSupported() matches spec: defined('SO_REUSEPORT') && PHP_OS_FAMILY !== 'Windows'
• All issue #7 acceptance criteria satisfied
• No security issues, secrets, PII, or injection vectors
• Code follows existing project patterns

⚠️ Self-review — awaiting human approval.