M1I09: SocketFactory (fallback chain)

[s2x]

Summary

Component	Description
Issue	#11 — SocketFactory with fallback chain
Files	src/Server/Socket/SocketFactory.php, tests/Server/Socket/SocketFactoryTest.php
Changes	Static factory with fallback: REUSE_PORT → ForkSharedProxy if unsupported

Acceptance criteria

• create(MASTER) returns MasterProxy
• create(FORK_SHARED) returns ForkSharedProxy
• create(REUSE_PORT) returns ReusePortProxy if supported, else ForkSharedProxy
• Lint + tests pass

Closes #11

[s2x]

Review Summary — Round 1

#	Severity	File:Line	Finding
1	MEDIUM	tests/Server/Socket/SocketFactoryTest.php:35	Fallback test assertion is too weak — doesn't validate fallback logic

Follow-up Observations

• SocketFactory::create() accepts $port and $protocol but never passes them to proxy constructors — this is a known decision per watpliwosci.md #6 ("params not needed in proxy constructors — createSocket() receives them at call time"). Consider documenting this in a PHPDoc @param tag to clarify intent.
• Static factory with hardcoded new calls prevents mocking/stubbing in unit tests — consider making the factory instantiable with overridable methods for future testability.
• Consider adding a @throws docblock to document potential \UnhandledMatchError if new ProxyType enum values are added without corresponding factory cases.

What's Fine ✔️

• All acceptance criteria satisfied: MASTER → MasterProxy, FORK_SHARED → ForkSharedProxy, REUSE_PORT → ReusePortProxy/ForkSharedProxy
• All tests pass (3/3, 3 assertions)
• No security issues: no leaked credentials, PII, injection vectors, or insecure crypto
• match expression is exhaustive for current ProxyType enum values
• Code follows the milestone spec and plan exactly

[s2x]

Review Summary — Round 2

#	Severity	Finding	Status
—	MEDIUM	Unused $port/$protocol params in create()	Known decision — watpliwosci.md #6, accepted by design

Previous Finding Resolved

• ✅ Fallback test split into testCreateReusePortReturnsReusePortWhenSupported + testCreateReusePortFallsBackToForkSharedWhenNotSupported — each path now explicitly tested with markTestSkipped for the inverse condition.

Follow-up Observations

• Missing class-level PHPDoc on SocketFactory — MasterProxy has one but the main entry point for proxy selection doesn't. Consider adding a short description of the fallback chain. (effort: low)

What's Fine ✅

• All 4 acceptance criteria met — MASTER → MasterProxy, FORK_SHARED → ForkSharedProxy, REUSE_PORT → ReusePortProxy (supported) / ForkSharedProxy (unsupported)
• 4 tests (3 pass + 1 skipped per platform), lint + CI green on PHP 8.2–8.5
• No security issues, no secrets, no PII
• Signature and fallback logic match the milestone doc exactly
• match expression is exhaustive — PHP enforces all ProxyType cases handled