Location
src/Phar/BinaryComposer.php:17
Problem
The MAGIC_BYTES constant is declared public but no code outside BinaryComposer references it. Exposing internal constants widens the public API by accident.
What to change
- Reduce the constant's visibility to
private (or protected if subclasses are expected).
- If external consumers genuinely need it, document the use case and keep
public.
Acceptance criteria
Location
src/Phar/BinaryComposer.php:17Problem
The
MAGIC_BYTESconstant is declaredpublicbut no code outsideBinaryComposerreferences it. Exposing internal constants widens the public API by accident.What to change
private(orprotectedif subclasses are expected).public.Acceptance criteria
MAGIC_BYTESisprivate(preferred) orprotected, unless a documented external consumer exists.vendor/bin/phpunit).