Location
src/Resolver.php:22
Problem
An inner closure declares a parameter named $args while the outer scope destructures [$app, $args] already. The inner $args shadows the outer one, making the code easy to misread — a reader has to mentally track which $args is in scope on every line.
What to change
- Rename either the outer or the inner
$args to something distinct (e.g. $runtimeArgs for the outer or $invokeArgs for the inner).
- No logic change.
Acceptance criteria
Location
src/Resolver.php:22Problem
An inner closure declares a parameter named
$argswhile the outer scope destructures[$app, $args]already. The inner$argsshadows the outer one, making the code easy to misread — a reader has to mentally track which$argsis in scope on every line.What to change
$argsto something distinct (e.g.$runtimeArgsfor the outer or$invokeArgsfor the inner).Acceptance criteria
$argssymbols no longer share a name in overlapping scopes.vendor/bin/phpunit).