Location
src/DependencyInjection/WorkermanCompilerPass.php:28
Problem
The compiler pass calls uasort on $responseConverterStrategies (mutating it), then iterates $tasks and $processes via array_keys() without the same sort step. The inconsistency makes it unclear whether ordering matters for tasks/processes too.
What to change
- Decide whether tasks/processes need deterministic ordering. If yes, apply the same sort consistently. If no, document why the strategies need it and the others do not.
- Standardise the iteration style (e.g. always via
array_keys or always via direct foreach on the sorted array).
Acceptance criteria
Location
src/DependencyInjection/WorkermanCompilerPass.php:28Problem
The compiler pass calls
uasorton$responseConverterStrategies(mutating it), then iterates$tasksand$processesviaarray_keys()without the same sort step. The inconsistency makes it unclear whether ordering matters for tasks/processes too.What to change
array_keysor always via direct foreach on the sorted array).Acceptance criteria
vendor/bin/phpunit).