Skip to content

[Code Quality] WorkermanCommand allowedActions property is actually an error message #373

@s2x

Description

@s2x

Location

src/Command/WorkermanCommand.php:46

Problem

The property $allowedActions is named as if it holds a list of allowed actions, but its value is an error-message string. The name lies about the content, hurting readability.

What to change

  • Rename $allowedActions to $invalidActionMessage (or another name that matches the value).
  • Update any references accordingly.

Acceptance criteria

  • The property name accurately reflects its content.
  • All call sites are updated.
  • Existing tests pass (vendor/bin/phpunit).
  • No behavioural change observable to CLI users.

Metadata

Metadata

Assignees

No one assigned

    Labels

    code-qualityCode quality improvementsminorMinor priority - code quality

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions