Commit 237b400
Edward Chen
fix(ci): correct GITHUB_SHA fallback condition (STREQUAL not NOT)
The previous fallback used 'if(NOT TRANSCRIBE_BUILD_COMMIT ...)', but the
variable is initialized to "unknown" (a non-empty string = truthy in CMake),
so 'NOT <var>' was always FALSE and the GITHUB_SHA/GITHUB_REF_NAME fallback
never ran — Linux .so build-id still showed 'unknown unknown'. Use
'STREQUAL "unknown"' instead, matching llama.cpp-omni's build-info.cmake.
Verified: in a no-.git directory with GITHUB_SHA set, the capture now falls
back to the short SHA (commit abc123d, branch main).1 parent e283996 commit 237b400
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
99 | | - | |
| 99 | + | |
100 | 100 | | |
101 | 101 | | |
102 | | - | |
| 102 | + | |
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
| |||
0 commit comments