Skip to content

Commit 237b400

Browse files
author
Edward Chen
committed
fix(ci): correct GITHUB_SHA fallback condition (STREQUAL not NOT)
The previous fallback used 'if(NOT TRANSCRIBE_BUILD_COMMIT ...)', but the variable is initialized to "unknown" (a non-empty string = truthy in CMake), so 'NOT <var>' was always FALSE and the GITHUB_SHA/GITHUB_REF_NAME fallback never ran — Linux .so build-id still showed 'unknown unknown'. Use 'STREQUAL "unknown"' instead, matching llama.cpp-omni's build-info.cmake. Verified: in a no-.git directory with GITHUB_SHA set, the capture now falls back to the short SHA (commit abc123d, branch main).
1 parent e283996 commit 237b400

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,10 +96,10 @@ endif()
9696
# provenance instead of "unknown". GITHUB_SHA is the full 40-char commit; trim
9797
# it to the short form so it matches the `git rev-parse --short HEAD` shape
9898
# captured above.
99-
if(NOT TRANSCRIBE_BUILD_COMMIT AND DEFINED ENV{GITHUB_SHA})
99+
if(TRANSCRIBE_BUILD_COMMIT STREQUAL "unknown" AND DEFINED ENV{GITHUB_SHA})
100100
string(SUBSTRING "$ENV{GITHUB_SHA}" 0 7 TRANSCRIBE_BUILD_COMMIT)
101101
endif()
102-
if(NOT TRANSCRIBE_BUILD_BRANCH AND DEFINED ENV{GITHUB_REF_NAME})
102+
if(TRANSCRIBE_BUILD_BRANCH STREQUAL "unknown" AND DEFINED ENV{GITHUB_REF_NAME})
103103
set(TRANSCRIBE_BUILD_BRANCH "$ENV{GITHUB_REF_NAME}")
104104
endif()
105105
string(TIMESTAMP TRANSCRIBE_BUILD_DATE "%Y-%m-%dT%H:%M:%SZ" UTC)

0 commit comments

Comments
 (0)