Diff status not returned in revision search

[jbarr21]

Our version of phabricator doesn't return the status for the differential.revision.search endpoint which causes the app to crash on launch (after credentials are added)

ours API returns:

{
  "result": {
    "data": [
      {
        "id": REV_ID,
        "type": "DREV",
        "phid": REV_PHID,
        "fields": {
          "title": "Title text",
          "authorPHID": USER_PHID,
          "dateCreated": 1509610240,
          "dateModified": 1509610514,
          "policy": {
            "view": PROJECT_PHID,
            "edit": "users"
          },
          "revertPlan": "revert"
        },
        "attachments": {}
      },
      ...

error log:

fatal error: 'try!' expression unexpectedly raised an error: Swift.DecodingError.keyNotFound(stabricator.Fields.(CodingKeys in _0DE5581E513B0DCCBEB48AC5CE099040).status, Swift.DecodingError.Context(codingPath: [stabricator.Response<stabricator.ListResult<stabricator.Diff>>.(CodingKeys in _0DE5581E513B0DCCBEB48AC5CE099040).result, stabricator.ListResult<stabricator.Diff>.(CodingKeys in _0DE5581E513B0DCCBEB48AC5CE099040).data, Foundation.(_JSONKey in _12768CA107A31EF2DCE034FD75B541C9)(stringValue: "Index 0", intValue: Optional(0)), stabricator.Diff.(CodingKeys in _0DE5581E513B0DCCBEB48AC5CE099040).fields], debugDescription: "No value associated with key status (\"status\").", underlyingError: nil)): file /Library/Caches/com.apple.xbs/Sources/swiftlang/swiftlang-900.0.65.2/src/swift/stdlib/public/core/ErrorType.swift, line 181
2017-11-02 01:26:51.784598-0700 stabricator[25300:4730138] fatal error: 'try!' expression unexpectedly raised an error: Swift.DecodingError.keyNotFound(stabricator.Fields.(CodingKeys in _0DE5581E513B0DCCBEB48AC5CE099040).status, Swift.DecodingError.Context(codingPath: [stabricator.Response<stabricator.ListResult<stabricator.Diff>>.(CodingKeys in _0DE5581E513B0DCCBEB48AC5CE099040).result, stabricator.ListResult<stabricator.Diff>.(CodingKeys in _0DE5581E513B0DCCBEB48AC5CE099040).data, Foundation.(_JSONKey in _12768CA107A31EF2DCE034FD75B541C9)(stringValue: "Index 0", intValue: Optional(0)), stabricator.Diff.(CodingKeys in _0DE5581E513B0DCCBEB48AC5CE099040).fields], debugDescription: "No value associated with key status (\"status\").", underlyingError: nil)): file /Library/Caches/com.apple.xbs/Sources/swiftlang/swiftlang-900.0.65.2/src/swift/stdlib/public/core/ErrorType.swift, line 181
(lldb) 

[danh32]

Thanks for the detailed report!

It's very interesting that the response is different, I wonder if we're on different versions of Phabricator or something.

I'll try to get a fix up soon!